KofTwentyTwo/AppKit
2
0 Fork 0
Code Issues 22 Pull Requests 4 Actions Packages Projects Releases 1 Wiki Activity

ci(review): deploy acknowledged current-commit review enforcement #13

New Issue
Open
opened 2026-10-10 16:58:43 +00:00 by KofTwentyTwo · 6 comments
KofTwentyTwo commented 2026-10-10 16:58:43 +00:00 (Migrated from github.com)
Copy link
Copy source

Problem

Scorecard alerts #1 and #4 reflect the chosen single-maintainer policy. PR #2 had no recorded automated review. A fail-closed comment-based review gate and tests are prepared locally but not deployed.

Acceptance criteria

Verify and publish the gate; bootstrap a real acknowledged current-SHA review; require its contexts while preserving existing protections; document EX-0001 and verify future PR enforcement; accurately resolve alert disposition.

Scope

AppKit first, then starter.

This issue is part of the user-requested AppKit readiness remediation. Local work is not completion until the applicable published/runtime state and checks are verified. Substantial AI assistance: Codex.

## Problem Scorecard alerts #1 and #4 reflect the chosen single-maintainer policy. PR #2 had no recorded automated review. A fail-closed comment-based review gate and tests are prepared locally but not deployed. ## Acceptance criteria Verify and publish the gate; bootstrap a real acknowledged current-SHA review; require its contexts while preserving existing protections; document EX-0001 and verify future PR enforcement; accurately resolve alert disposition. ## Scope AppKit first, then starter. This issue is part of the user-requested AppKit readiness remediation. Local work is not completion until the applicable published/runtime state and checks are verified. Substantial AI assistance: Codex.
KofTwentyTwo commented 2026-10-10 17:52:25 +00:00 (Migrated from github.com)
Copy link
Copy source

Trusted current-commit review controls are committed locally in AppKit 36886cbaae8810bf9c9a3c85867a2cee51d0ba3d.

The issue-comment workflow executes only trusted workflow-commit code, validates the current PR SHA and maintainer-owned acknowledgement, and fails closed. Seven regression tests pass. Contribution and PR guidance explain re-review after a new commit and the single-maintainer limitation.

Remaining: bootstrap the workflow on main, validate its live behavior, then require the check. No acknowledgement has been made on the maintainer's behalf, and no branch rules were changed. Signed commit; AI assistance: Codex (GPT-6).

Trusted current-commit review controls are committed locally in AppKit `36886cbaae8810bf9c9a3c85867a2cee51d0ba3d`. The issue-comment workflow executes only trusted workflow-commit code, validates the current PR SHA and maintainer-owned acknowledgement, and fails closed. Seven regression tests pass. Contribution and PR guidance explain re-review after a new commit and the single-maintainer limitation. Remaining: bootstrap the workflow on main, validate its live behavior, then require the check. No acknowledgement has been made on the maintainer's behalf, and no branch rules were changed. Signed commit; AI assistance: Codex (GPT-6).
KofTwentyTwo commented 2026-10-10 19:55:56 +00:00 (Migrated from github.com)
Copy link
Copy source

Implemented and saved locally in starter commit 3dd5adf89d4f07cd40092151eef9cc44c5a0a969 on fix/template-onboarding. No push, repository creation, settings mutation, merge or publication has been performed.

  • Added offline preview, explicit apply and read-only validation for generated repository controls, with thirteen non-secret API requests.
  • Apply requires the current head of an open bootstrap PR and every required GitHub Actions check to succeed. Rulesets bind contexts to the observed Actions app; main has no bypass; release permits only v* tags. Existing conflicting rules/environment policies are preserved and rejected before writes.
  • Propagated the human-acknowledged current-commit review validator, locked JavaScript tools, lint/signature gates and CodeQL coverage to generated apps. Custom owner/reviewer substitution passes in both CLI variants.
  • Template packages exclude node_modules and worktree Git metadata. Added a complete owner bootstrap/runbook and threat-model boundaries.

Validation: 13 setup boundary tests plus four coverage tests pass; seven Node tests, PowerShell analysis, ESLint, workflow/security/documentation lint and all commit hooks pass. npm verified 83 signatures and 20 attestations. Packed template generation with owner Example produces correct setup/review identities; both CLI/no-CLI generated solutions pass locked restore and zero-warning build.

Remaining acceptance: authorized disposable live repository creation/push, hosted CI, real apply/readback and failing-PR enforcement; inventory/public template publication and human review acknowledgement. The issue remains open for that evidence. Substantial AI assistance: Codex (GPT-6).

Implemented and saved locally in starter commit `3dd5adf89d4f07cd40092151eef9cc44c5a0a969` on `fix/template-onboarding`. No push, repository creation, settings mutation, merge or publication has been performed. - Added offline preview, explicit apply and read-only validation for generated repository controls, with thirteen non-secret API requests. - Apply requires the current head of an open bootstrap PR and every required GitHub Actions check to succeed. Rulesets bind contexts to the observed Actions app; main has no bypass; release permits only v* tags. Existing conflicting rules/environment policies are preserved and rejected before writes. - Propagated the human-acknowledged current-commit review validator, locked JavaScript tools, lint/signature gates and CodeQL coverage to generated apps. Custom owner/reviewer substitution passes in both CLI variants. - Template packages exclude node_modules and worktree Git metadata. Added a complete owner bootstrap/runbook and threat-model boundaries. Validation: 13 setup boundary tests plus four coverage tests pass; seven Node tests, PowerShell analysis, ESLint, workflow/security/documentation lint and all commit hooks pass. npm verified 83 signatures and 20 attestations. Packed template generation with owner Example produces correct setup/review identities; both CLI/no-CLI generated solutions pass locked restore and zero-warning build. Remaining acceptance: authorized disposable live repository creation/push, hosted CI, real apply/readback and failing-PR enforcement; inventory/public template publication and human review acknowledgement. The issue remains open for that evidence. Substantial AI assistance: Codex (GPT-6).
KofTwentyTwo commented 2026-10-10 22:49:34 +00:00 (Migrated from github.com)
Copy link
Copy source

Current AppKit review at bbf7efdba8e3d3a4cfe141923153dce53dc11fda is recorded with resolved code findings, not a maintainer acknowledgement. Fresh locked restore/zero-warning full build/format, 161 unit tests with 100% core/update coverage, 14 WinUI/WPF UI tests, seven review-validator tests and ESLint pass. Retained 40 script tests remain passing. Both actual generated variants now pass complete local channel upgrades and 19 UI checks each; hosted enforcement and genuine owner acknowledgement remain required.

The shared rollout is now a separate branch based directly on published standards v1.0.0 (7c69368): helper 3334d02b907d44f4dca1b32553ad2bd6203c7b7f, integration 5887a839b23a405aa6b8148af61361e19da07643. Its exact helper is an ancestor, module bytes match the reviewed AppKit source, and only eleven signing-related files differ. All 35 signing/wrapper tests, workflow syntax/offline security, Markdown and existing security/message hooks pass. Both commits verify signed/DCO; older shared preparation and original checkouts remain intact.

Prepared local files: artifacts/readiness-issues/{APPKIT-REVIEW-bbf7efd.md,STANDARDS-REVIEW-5887a83.md,APPKIT-PR-bbf7efd.md,STANDARDS-PR-5887a83.md,ROLLOUT-bbf7efd-5887a83.md}. These describe exact branches, validation, unresolved hosted/bootstrap/publication criteria and administrator signing actions. Helper references remain unpublished preparation; do not repin consumers or remove release preflight until the reviewed builder is available and actual verified signing configuration is established. No successful AppKit signing is claimed.

Read-only hosted checks still show AppKit main 839fb72, standards main 7c69368, and no public KofTwentyTwo/windows-app-template repository. No push, PR, merge, new release, settings/Azure change or login retry occurred. Thirty signed local preparation commits are retained (22 across active rollout branches, eight older shared preparation commits). Azure retry remains owner-deferred. Current-SHA owner acknowledgement and live review/check enforcement must still be bootstrapped.

Current AppKit review at `bbf7efdba8e3d3a4cfe141923153dce53dc11fda` is recorded with resolved code findings, not a maintainer acknowledgement. Fresh locked restore/zero-warning full build/format, 161 unit tests with 100% core/update coverage, 14 WinUI/WPF UI tests, seven review-validator tests and ESLint pass. Retained 40 script tests remain passing. Both actual generated variants now pass complete local channel upgrades and 19 UI checks each; hosted enforcement and genuine owner acknowledgement remain required. The shared rollout is now a separate branch based directly on published standards v1.0.0 (`7c69368`): helper `3334d02b907d44f4dca1b32553ad2bd6203c7b7f`, integration `5887a839b23a405aa6b8148af61361e19da07643`. Its exact helper is an ancestor, module bytes match the reviewed AppKit source, and only eleven signing-related files differ. All 35 signing/wrapper tests, workflow syntax/offline security, Markdown and existing security/message hooks pass. Both commits verify signed/DCO; older shared preparation and original checkouts remain intact. Prepared local files: `artifacts/readiness-issues/{APPKIT-REVIEW-bbf7efd.md,STANDARDS-REVIEW-5887a83.md,APPKIT-PR-bbf7efd.md,STANDARDS-PR-5887a83.md,ROLLOUT-bbf7efd-5887a83.md}`. These describe exact branches, validation, unresolved hosted/bootstrap/publication criteria and administrator signing actions. Helper references remain unpublished preparation; do not repin consumers or remove release preflight until the reviewed builder is available and actual verified signing configuration is established. No successful AppKit signing is claimed. Read-only hosted checks still show AppKit main `839fb72`, standards main `7c69368`, and no public `KofTwentyTwo/windows-app-template` repository. No push, PR, merge, new release, settings/Azure change or login retry occurred. Thirty signed local preparation commits are retained (22 across active rollout branches, eight older shared preparation commits). Azure retry remains owner-deferred. Current-SHA owner acknowledgement and live review/check enforcement must still be bootstrapped.
KofTwentyTwo commented 2026-10-10 22:55:33 +00:00 (Migrated from github.com)
Copy link
Copy source

The authorized topic branches are now pushed and draft PRs are open:

Shared signing run 38093017631 completed successfully, including Windows signing tests, conformance, docs, CodeQL, security and PR gates. These are preparation tests, not proof of Azure authentication or real signatures.

AppKit's initial hosted run passed build-test, UI, JavaScript and security checks. It exposed a pinned analyzer recursive-analysis crash and uri-js development-license policy rejection, now tracked in #26. A signed, reviewed correction checks all nine PowerShell files separately with unchanged rules; all pass locally, and current-head hosted validation is running. The license failure remains enforced pending a recorded policy exception.

Both PRs remain drafts. Owner review acknowledgement, review-gate/settings bootstrap, shared publication/consumer adoption, public starter rollout and actual AppKit signing remain required where applicable. Push/draft approval did not authorize merge, release, repository creation, settings or Azure login retry.

The authorized topic branches are now pushed and draft PRs are open: - AppKit #25: https://github.com/KofTwentyTwo/AppKit/pull/25 (current signed head 09f9e0777e14043403de350477097ec212cbe61a) - Shared signing #31: https://github.com/KofTwentyTwo/standards/pull/31 (5887a839b23a405aa6b8148af61361e19da07643) Shared signing run 38093017631 completed successfully, including Windows signing tests, conformance, docs, CodeQL, security and PR gates. These are preparation tests, not proof of Azure authentication or real signatures. AppKit's initial hosted run passed build-test, UI, JavaScript and security checks. It exposed a pinned analyzer recursive-analysis crash and uri-js development-license policy rejection, now tracked in #26. A signed, reviewed correction checks all nine PowerShell files separately with unchanged rules; all pass locally, and current-head hosted validation is running. The license failure remains enforced pending a recorded policy exception. Both PRs remain drafts. Owner review acknowledgement, review-gate/settings bootstrap, shared publication/consumer adoption, public starter rollout and actual AppKit signing remain required where applicable. Push/draft approval did not authorize merge, release, repository creation, settings or Azure login retry.
KofTwentyTwo commented 2026-10-10 23:00:58 +00:00 (Migrated from github.com)
Copy link
Copy source

Owner approved the separate proposal push/draft PR. Opened https://github.com/KofTwentyTwo/standards/pull/32 at cd20e945bd9809745d4d872ae29dd2496b5a9644, targeting main as a draft. Run 38093461441 is in progress; docs/internal-link, conformance, dependency-review, title/DCO, secrets and workflow checks have passed.

EX-0009 remains Proposed. This push approval does not approve the exception or activate a caller exemption. AppKit's dependency license gate still fails; all vulnerability/SCA checks stay enforced. Review/mark Open through the normal register process is required before separately enabling the exact-version exemption.

AppKit #25 current build, format, UI, scripts (40 cases), security and Actions/JavaScript CodeQL pass. C# manual build has completed; analysis is running. Shared signing #31 is fully green. No merge, release, repository/settings or Azure changes occurred.

Owner approved the separate proposal push/draft PR. Opened https://github.com/KofTwentyTwo/standards/pull/32 at cd20e945bd9809745d4d872ae29dd2496b5a9644, targeting main as a draft. Run 38093461441 is in progress; docs/internal-link, conformance, dependency-review, title/DCO, secrets and workflow checks have passed. EX-0009 remains Proposed. This push approval does not approve the exception or activate a caller exemption. AppKit's dependency license gate still fails; all vulnerability/SCA checks stay enforced. Review/mark Open through the normal register process is required before separately enabling the exact-version exemption. AppKit #25 current build, format, UI, scripts (40 cases), security and Actions/JavaScript CodeQL pass. C# manual build has completed; analysis is running. Shared signing #31 is fully green. No merge, release, repository/settings or Azure changes occurred.
KofTwentyTwo commented 2026-10-10 23:02:36 +00:00 (Migrated from github.com)
Copy link
Copy source

Final hosted checkpoint:

  • AppKit draft #25, head 09f9e0777e: build-test, format, WinUI/WPF UI, PowerShell (40/40), JavaScript/review tests, title/DCO, security and all three CodeQL language checks succeed. CodeQL run 38093181044 is completed SUCCESS. The only failed check is dependency-review's uri-js tooling-license policy rejection.
  • Shared signing draft #31, head 5887a83: run 38093017631 completed SUCCESS, all applicable checks.
  • Proposed tooling-license draft #32, head cd20e94: run 38093461441 completed SUCCESS, all applicable checks.

No CI job is still pending. License-policy acceptance remains unresolved: EX-0009 is Proposed, not Open/approved, and no caller exemption is enabled. Both the exact-version exception and any eventual caller correction need the normal reviewed process and updated current-head acknowledgement. No gate was weakened to obtain these results.

All three branches were pushed with explicit approval and remain drafts. No merge, release, starter creation/push, settings or Azure mutation/login retry occurred. Hosted results do not prove actual AppKit Azure signing, production feeds or full standards compliance. Scoped implementation/tests are verified; broader acceptance tickets remain open.

Final hosted checkpoint: - AppKit draft #25, head 09f9e0777e14043403de350477097ec212cbe61a: build-test, format, WinUI/WPF UI, PowerShell (40/40), JavaScript/review tests, title/DCO, security and all three CodeQL language checks succeed. CodeQL run 38093181044 is completed SUCCESS. The only failed check is dependency-review's uri-js tooling-license policy rejection. - Shared signing draft #31, head 5887a83: run 38093017631 completed SUCCESS, all applicable checks. - Proposed tooling-license draft #32, head cd20e94: run 38093461441 completed SUCCESS, all applicable checks. No CI job is still pending. License-policy acceptance remains unresolved: EX-0009 is Proposed, not Open/approved, and no caller exemption is enabled. Both the exact-version exception and any eventual caller correction need the normal reviewed process and updated current-head acknowledgement. No gate was weakened to obtain these results. All three branches were pushed with explicit approval and remain drafts. No merge, release, starter creation/push, settings or Azure mutation/login retry occurred. Hosted results do not prove actual AppKit Azure signing, production feeds or full standards compliance. Scoped implementation/tests are verified; broader acceptance tickets remain open.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
accessibility
Barrier affecting people with disabilities
 bug
Something isn't working
 deferred
Agreed follow-up, unscheduled
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 needs-owner
Blocked on the owner
 priority
Work this first
 quality
Tests, gates, and code quality
 question
Further information is requested
 refactor
Internal restructuring, no behavior change
 release
Release and packaging
 wontfix
This will not be worked on
No labels priority quality
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/AppKit#13