Files
AppKit/docs/adr/0003-coverage-scope.md
james.maesandClaude Opus 5.5 839fb72bec chore: adopt the KofTwentyTwo standards (#2)
## What

Brings AppKit into conformance with
[KofTwentyTwo/standards](https://github.com/KofTwentyTwo/standards).
Reviewable commit by commit:

| Commit | Change |
| --- | --- |
| build | Quality gate from `configs/dotnet` (analyzers incl. Meziantou,
warnings as errors), `packages.lock.json` per project, locked-mode
restore |
| style | Kingsrook layout and LF line endings, produced mechanically by
`dotnet format` (formatting only) |
| docs | SPDX license header on every C# file |
| refactor | Real code changes: analyzer findings fixed (one type per
file, regex timeouts, async void, …) and header comments on every type
and member |
| ci | Old workflows replaced by callers of the shared standards
workflows (PR gates, security, CodeQL, .NET CI, NuGet release with SBOM
+ attestation + trusted publishing), Scorecard |
| docs | README, CONTRIBUTING (GitHub Flow, DCO, signing), SECURITY,
CODEOWNERS, templates, Dependabot, threat model, ADRs, RELEASING |

Also includes `dev`'s CI fix, so it supersedes #1; the `dev` branch goes
away under GitHub Flow.

## Why

AppKit is the first Product repository to adopt the standards. Static
conformance before: 16 FAIL; after: 0 FAIL, 0 WARN (the remaining
UNKNOWN rows are GitHub settings and rulesets, applied separately).

## How tested

Locally with `CI=true` (lock files enforced): locked restore x64 and
ARM64; zero-warning x64 build; 115 unit tests with 100% line coverage of
`KofTwentyTwo.AppKit` and `KofTwentyTwo.AppKit.Updates`; 12 FlaUI UI
tests (WinUI + WPF samples); `dotnet format --verify-no-changes
--severity warn` clean; pack produces 4 packages + symbols; actionlint,
zizmor (pedantic), gitleaks clean.

The UI tests caught a regression introduced while fixing MA0147 (the WPF
splash stopped dismissing because no UI context existed yet); fixed by
starting the countdown through the dispatcher in both packages.

## Notes

- `ci.yml` and `release.yml` are pinned to KofTwentyTwo/standards#3's
head commit; they are repinned after that PR merges.
- This pull request's new check names become required checks once the
repository's rulesets are updated.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Signed-off-by: James Maes <james@kof22.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-09 14:43:17 -05:00

1.5 KiB

ADR-0003: Hold the UI-framework-free packages at 100% line coverage

  • Status: Accepted
  • Date: 2026-10-09
  • Pull request: recorded retroactively for the initial design

Context

The KofTwentyTwo testing standard requires 100% line coverage for libraries published for others to consume and for UI-free core logic (K22-TEST-10). WinUI and WPF views need a live compositor and a desktop session, which unit tests do not have.

Options considered

Option A: measure every package

  • Pros: one number.
  • Cons: the view packages cannot reach 100% without a desktop, so the gate would be lowered for everyone or riddled with exclusions.

Option B: measure KofTwentyTwo.AppKit and KofTwentyTwo.AppKit.Updates at 100%

  • Pros: the gate is meaningful and cheap to keep; it pushes logic out of the views and into tested code.
  • Cons: the view packages rely on the FlaUI end-to-end tests instead of a number.

Decision

Option B. coverage.runsettings measures only the two framework-free packages, and build/Assert-Coverage.ps1 fails CI below 100%. Exclusions use [ExcludeFromCodeCoverage(Justification = ...)] only for thin pass-throughs that need an installed app or the network.

Consequences

  • New logic belongs in the framework-free packages; views stay thin.
  • The UI packages are verified by the sample apps' UI tests in CI.
  • Security: none directly; tested code paths include the secret vault and the update guarding.