james.maesandClaude Opus 5.5
839fb72bec
## What Brings AppKit into conformance with [KofTwentyTwo/standards](https://github.com/KofTwentyTwo/standards). Reviewable commit by commit: | Commit | Change | | --- | --- | | build | Quality gate from `configs/dotnet` (analyzers incl. Meziantou, warnings as errors), `packages.lock.json` per project, locked-mode restore | | style | Kingsrook layout and LF line endings, produced mechanically by `dotnet format` (formatting only) | | docs | SPDX license header on every C# file | | refactor | Real code changes: analyzer findings fixed (one type per file, regex timeouts, async void, …) and header comments on every type and member | | ci | Old workflows replaced by callers of the shared standards workflows (PR gates, security, CodeQL, .NET CI, NuGet release with SBOM + attestation + trusted publishing), Scorecard | | docs | README, CONTRIBUTING (GitHub Flow, DCO, signing), SECURITY, CODEOWNERS, templates, Dependabot, threat model, ADRs, RELEASING | Also includes `dev`'s CI fix, so it supersedes #1; the `dev` branch goes away under GitHub Flow. ## Why AppKit is the first Product repository to adopt the standards. Static conformance before: 16 FAIL; after: 0 FAIL, 0 WARN (the remaining UNKNOWN rows are GitHub settings and rulesets, applied separately). ## How tested Locally with `CI=true` (lock files enforced): locked restore x64 and ARM64; zero-warning x64 build; 115 unit tests with 100% line coverage of `KofTwentyTwo.AppKit` and `KofTwentyTwo.AppKit.Updates`; 12 FlaUI UI tests (WinUI + WPF samples); `dotnet format --verify-no-changes --severity warn` clean; pack produces 4 packages + symbols; actionlint, zizmor (pedantic), gitleaks clean. The UI tests caught a regression introduced while fixing MA0147 (the WPF splash stopped dismissing because no UI context existed yet); fixed by starting the countdown through the dispatcher in both packages. ## Notes - `ci.yml` and `release.yml` are pinned to KofTwentyTwo/standards#3's head commit; they are repinned after that PR merges. - This pull request's new check names become required checks once the repository's rulesets are updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: James Maes <james@kof22.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
49 lines
1.5 KiB
C#
49 lines
1.5 KiB
C#
/*
|
|
* Copyright (c) 2026 James Maes (KofTwentyTwo)
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
namespace KofTwentyTwo.AppKit.Tests;
|
|
|
|
/// <summary>Tests for the splash and About credit text.</summary>
|
|
public class CreditsTests
|
|
{
|
|
/// <summary>ContactLine: joins what is set.</summary>
|
|
[Fact]
|
|
public void ContactLine_JoinsWhatIsSet()
|
|
{
|
|
var app = new AppInfo
|
|
{
|
|
Id = "gclo",
|
|
DisplayName = "gclo",
|
|
AuthorEmail = "james@kof22.com",
|
|
RepositoryUrl = new Uri("https://github.com/KofTwentyTwo/gclo"),
|
|
Website = new Uri("https://kof22.com/"),
|
|
};
|
|
Assert.Equal("james@kof22.com · github.com/KofTwentyTwo · kof22.com", Credits.ContactLine(app));
|
|
}
|
|
|
|
|
|
|
|
/// <summary>ContactLine: empty when nothing is set.</summary>
|
|
[Fact]
|
|
public void ContactLine_EmptyWhenNothingIsSet()
|
|
{
|
|
Assert.Equal("", Credits.ContactLine(new AppInfo { Id = "x", DisplayName = "X" }));
|
|
Assert.Throws<ArgumentNullException>(() => Credits.ContactLine(null!));
|
|
}
|
|
|
|
|
|
|
|
/// <summary>The owner profile is host/owner for any repository URL, or just the host when the path is empty.</summary>
|
|
[Theory]
|
|
[InlineData(null, null)]
|
|
[InlineData("https://github.com/", "github.com")]
|
|
[InlineData("https://github.com/owner", "github.com/owner")]
|
|
[InlineData("https://github.com/owner/repo/", "github.com/owner")]
|
|
public void OwnerProfile(string? url, string? expected)
|
|
{
|
|
Assert.Equal(expected, Credits.OwnerProfile(url is null ? null : new Uri(url)));
|
|
}
|
|
}
|