Files
AppKit/src/KofTwentyTwo.AppKit.WinUI/DialogGuard.cs
T
james.maesandClaude Opus 5.5 20c95cffaa refactor: fix analyzer findings and add header comments
Fixes every finding the new quality gate reports, without changing behavior:

- One type per file (MA0048): AppBrand, Attribution, NullActivityLog,
  LogSnapshot, ISanitizable, AppTheme, UpdateCheckResult, UpdateText,
  IUpdateBackend, ContentDialogPrompter, WindowExtensions, MessageBoxPrompter,
  and the samples' SampleSettings/SampleSettingsContext get their own files
  (the samples now link samples/Shared/*.cs).
- Regex match timeouts on the two generated regexes (MA0009).
- AppInfo.Id reports nameof(value) as the parameter (MA0015); test updated.
- Splash dismissal is a named DismissAfterAsync started through the
  dispatcher (MA0147, MA0134), and the WinUI splash constructor is split into
  builders (MA0051). The WPF countdown must go through the dispatcher: the
  sample builds its window before Application.Run, when no synchronization
  context exists.
- The WinUI sample's startup update check is a named method (MA0147).
- CA1859 in BrandTool and the version tests; private static readonly fields
  renamed to s_camelCase (IDE1006).
- A header comment on every type and method (K22-CODE-09/CS-04): hand-written
  for library, sample, and tool code; test methods summarize their
  Subject_Behavior names.

Verified: zero-warning x64 build, 115 unit tests with 100% line coverage of
KofTwentyTwo.AppKit and KofTwentyTwo.AppKit.Updates, 12 UI tests, and
dotnet format --verify-no-changes --severity warn.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
2026-10-09 10:23:40 -05:00

53 lines
1.5 KiB
C#

/*
* Copyright (c) 2026 James Maes (KofTwentyTwo)
* SPDX-License-Identifier: MIT
*/
using Microsoft.UI.Xaml.Controls;
namespace KofTwentyTwo.AppKit.WinUI;
/// <summary>
/// Serializes ContentDialog display. WinUI allows a single open ContentDialog per
/// XamlRoot, and a second ShowAsync does not queue: it throws a COMException which,
/// escaping an async void event handler, kills the process with a stowed exception
/// (0xc000027b). Open every dialog through <see cref="ShowAsync"/>, which ignores the
/// request while another dialog is on screen (the same no-op a user expects from
/// commands behind a modal). All calls run on the single UI thread, so the flag needs
/// no locking.
/// </summary>
public static class DialogGuard
{
private static bool s_dialogOpen;
/// <summary>True while a guarded dialog is on screen.</summary>
public static bool IsDialogOpen => s_dialogOpen;
/// <summary>
/// Shows <paramref name="dialog"/> unless another dialog is on screen. Returns the
/// dialog result, or null when the request was ignored; callers treat null like a
/// dismissal.
/// </summary>
public static async Task<ContentDialogResult?> ShowAsync(ContentDialog dialog)
{
ArgumentNullException.ThrowIfNull(dialog);
if(s_dialogOpen)
{
return null;
}
s_dialogOpen = true;
try
{
return await dialog.ShowAsync();
}
finally
{
s_dialogOpen = false;
}
}
}