From 911c3c17c57cd2b9898fc2460d37fd3860fbfc0a Mon Sep 17 00:00:00 2001
From: lwouis <lwouis@gmail.com>
Date: Tue, 1 Apr 2025 10:43:24 +0200
Subject: [PATCH] fix: window name would sometimes be empty (closes #4350)

---
 src/logic/Window.swift                     | 2 +-
 src/logic/events/AccessibilityEvents.swift | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/logic/Window.swift b/src/logic/Window.swift
index 6428f770..1493b699 100644
--- a/src/logic/Window.swift
+++ b/src/logic/Window.swift
@@ -54,7 +54,7 @@ class Window {
 
     init(_ application: Application) {
         self.application = application
-        title = application.localizedName
+        title = bestEffortTitle(nil)
         Window.globalCreationCounter += 1
         creationOrder = Window.globalCreationCounter
         Logger.debug(title ?? "nil", application.bundleIdentifier ?? "nil")
diff --git a/src/logic/events/AccessibilityEvents.swift b/src/logic/events/AccessibilityEvents.swift
index bcf04929..0972af55 100644
--- a/src/logic/events/AccessibilityEvents.swift
+++ b/src/logic/events/AccessibilityEvents.swift
@@ -186,7 +186,7 @@ func updateWindowSizeAndPositionAndFullscreen(_ element: AXUIElement, _ wid: CGW
         let position = try element.position()
         DispatchQueue.main.async {
             if let window = (window != nil ? window : (Windows.list.first { $0.isEqualRobust(element, wid) })) {
-                window.title = title
+                window.title = window.bestEffortTitle(title)
                 window.size = size
                 window.position = position
                 window.isMinimized = isMinimized