ci: build on the shared ci-workflows macOS workflow (build only) #2

Merged

james.maes merged 5 commits from ci/shared-macos into master 2026-11-08 23:33:41 +00:00

Conversation 0 Commits 5 Files Changed 5

+44 -4

james.maes commented 2026-11-08 23:27:45 +00:00

Owner

Copy link

Copy source

Moves Gitea CI to the shared ci-workflows macOS workflow (@v1, runner kof-macos-arm64), build only per the owner decision of 2026-11-08. Green: run 7262.

• Guard B (de-paywall marker + guard false else wrap in computeState()) and Guard C (no conflict markers outside docs/) ported from .github/workflows/guard.yml into the build commands.
• Unsigned Release scheme build. grogu has only Xcode 27.2, which rejects the app's 10.13 deployment target, so the CI build is a compile check at macOS 12.0 with only the deprecation group downgraded; the shipping build stays on the GitHub mirror (Xcode 26.0.1).
• Test scheme build-for-testing: the tests compile but are not run. Guard A (scripts/run_tests.sh, the anti-relock tests) is a documented local step in docs/contributing.md; the grogu runner has no GUI session for testmanagerd (run 730: build OK, xcodebuild test failed on com.apple.testmanagerd.control).
• config/test-base.xcconfig: the unit-test-only Xcode 27 fix from #1 (test target 12.0, only the deprecation group downgraded). #1's .gitleaksignore belonged to the retired central scan and is not carried; #1 can be closed once this merges.
• Fix: ExceptionsTab.applyContent and ExceptionEditorView.resolveHeaderAsync captured row/self strongly in the background closure while the inner closure asked for weak; Xcode 27's Swift reports the mismatch (#ImplicitStrongCapture), an error under warnings-as-errors. Both closures now capture weakly (run 7261 -> 7262).
• .github workflows unchanged (they run on the GitHub mirror: release, notarization, appcast).

🤖 Generated with Claude Code

Moves Gitea CI to the shared `ci-workflows` macOS workflow (`@v1`, runner `kof-macos-arm64`), build only per the owner decision of 2026-11-08. Green: run 7262. - **Guard B** (de-paywall marker + `guard false else` wrap in `computeState()`) and **Guard C** (no conflict markers outside `docs/`) ported from `.github/workflows/guard.yml` into the build commands. - Unsigned `Release` scheme build. grogu has only Xcode 27.2, which rejects the app's 10.13 deployment target, so the CI build is a compile check at macOS 12.0 with only the deprecation group downgraded; the shipping build stays on the GitHub mirror (Xcode 26.0.1). - `Test` scheme `build-for-testing`: the tests compile but are not run. **Guard A** (`scripts/run_tests.sh`, the anti-relock tests) is a documented local step in `docs/contributing.md`; the grogu runner has no GUI session for `testmanagerd` (run 730: build OK, `xcodebuild test` failed on `com.apple.testmanagerd.control`). - `config/test-base.xcconfig`: the unit-test-only Xcode 27 fix from #1 (test target 12.0, only the deprecation group downgraded). #1's `.gitleaksignore` belonged to the retired central scan and is not carried; #1 can be closed once this merges. - Fix: `ExceptionsTab.applyContent` and `ExceptionEditorView.resolveHeaderAsync` captured `row`/`self` strongly in the background closure while the inner closure asked for weak; Xcode 27's Swift reports the mismatch (`#ImplicitStrongCapture`), an error under warnings-as-errors. Both closures now capture weakly (run 7261 -> 7262). - `.github` workflows unchanged (they run on the GitHub mirror: release, notarization, appcast). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james.maes added 1 commit 2026-11-08 23:27:45 +00:00

ci: build on the shared ci-workflows macOS workflow (build only) ... c2be713446

Gitea CI on grogu (kof-macos-arm64): Guards B and C from guard.yml (the
de-paywall marker and if-false wrap in computeState(), no conflict markers),
an unsigned Release build, and build-for-testing of the Test scheme. The
tests (Guard A) are not run on CI: the runner has no GUI session for
testmanagerd; docs/contributing.md documents running scripts/run_tests.sh
locally before merging.

config/test-base.xcconfig takes the unit-test-only Xcode 27 fix from PR #1
(test target 12.0, deprecation group downgraded, every other warning still
an error); the shipping app keeps 10.13. The .github workflows stay for the
GitHub mirror.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

james.maes added 1 commit 2026-11-08 23:28:41 +00:00

ci: select Xcode 26.0.1, as ci_cd.yml does ... c675f1817f

Xcode 27.2 rejects the app's macOS 10.13 deployment target.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

james.maes added 1 commit 2026-11-08 23:29:48 +00:00

ci: compile the Release scheme at macOS 12.0 on Xcode 27 ... 756943f2b5

grogu has only Xcode 27.2, which rejects the 10.13 deployment target. The
CI build is a compile check at 12.0 with the deprecation group downgraded
(as config/test-base.xcconfig); the shipping build stays on the GitHub
mirror with Xcode 26.0.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

james.maes added 1 commit 2026-11-08 23:30:48 +00:00

ci: one-line Release build command ... 874971aa47

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

james.maes added 1 commit 2026-11-08 23:32:09 +00:00

fix: capture weakly in the outer resolve closures (Swift 6.3 ImplicitStrongCapture) ... da5779f872

The background closures in ExceptionsTab.applyContent and
ExceptionEditorView.resolveHeaderAsync captured row/self strongly while the
inner main-queue closure asked for weak; Xcode 27's Swift diagnoses the
mismatch (#ImplicitStrongCapture), an error under warnings-as-errors. Both
closures now capture weakly, so neither keeps the row or view alive while
the app info resolves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

james.maes merged commit 634dc9f688 into master 2026-11-08 23:33:41 +00:00

james.maes deleted branch ci/shared-macos 2026-11-08 23:33:41 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

chokepoint-refresh

De-paywall chokepoint needs re-verification after upstream change (PLAN §4.2)

conflict

Upstream sync had merge conflicts; needs manual resolution (PLAN §4.2)

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

sync

Upstream-sync PR (PLAN §4.2)

wontfix

This will not be worked on

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

forge-recovery (Forge Recovery) james.maes (James Maes)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KofTwentyTwo/CommandTabFree#2