4 Commits
Author SHA1 Message Date
james.maesandClaude Opus 4.7 b92d062f8b fix(tcc): explicit mic + camera permission requests in installVoice/installVision
Live test 2026-05-06 surfaced that the production app never actually triggered
the macOS mic or camera permission dialogs — the wizard's TCC stage was
explainer-only ("(later)") and the "first-use prompt" code that was supposed
to land later was never written. Result: AVAudioEngine opened cleanly, mic
input was silent, no wake-word ever fired, and CameraCapture.open() failed
.cameraDenied without ever asking.

Fix: explicit AVCaptureDevice.requestAccess(for:) calls at the first-use
boundary of each subsystem.

* App/AppDelegate.swift installVoice — checks mic auth status; on
  .notDetermined awaits requestAccess(for: .audio) BEFORE
  graphOwner.open(); on .denied/.restricted logs and returns dormant. Voice
  loop only proceeds with confirmed mic grant.

* App/AppDelegate.swift installVision — same pattern for camera. Checks
  status; .notDetermined → requestAccess(for: .video); .denied/.restricted
  surfaces the existing degradationStream banner via cameraDegradationTask.

* App/Wizard/WizardStageTCCView.swift — wizard rows updated from
  "Microphone (later)" / "Camera (later)" to "(auto-prompts shortly)" with
  body text matching reality: prompts fire automatically after the wizard,
  when the matching subsystem starts. The previous "later" copy implied
  indefinite deferral when actually the prompts fire ~5s after wizard
  completion.

Live verification:
- tccutil reset Microphone com.koftwentytwo.jarvis
- Launch → wizard appears → click through
- tccd log: "AUTHREQ_PROMPTING ... kTCCServiceMicrophone" — system
  dialog displayed
- After click-Allow: AudioGraph: probed format sampleRate=48000 channels=4,
  AudioGraphOwner: opened with variant <private>, WakeWordDAG: started
  ring-feed loop, VoiceController: starting

Voice 87/87 pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-06 11:26:44 -05:00
james.maes 4b5f535d86 fix(wizard): single-window reuse + always-closable + Re-check + System-Settings-fallback
User reported three real wizard bugs after the previous round of fixes:

1. Setup… opens a new window every click. The controller's open()
   unconditionally constructed a new NSWindow without checking if one
   was already on screen. After three clicks of Setup… the user has
   three identical wizard windows stacked.

2. No close controls. The first-launch+apiKey branch disabled the
   close button by setting .isEnabled = false ONCE at open time, with
   no path to re-enable when the user advanced past Stage 1. Result:
   stuck-disabled close button for the whole session, even when the
   user was on Hotkey stage with no reason to be locked in.

3. Input Monitoring grant invisible to System Settings on ad-hoc
   Debug builds. Even after IOHIDRequestAccess fires, the bundle may
   not appear in System Settings → Privacy & Security → Input
   Monitoring because the ad-hoc signature has TeamIdentifier='not
   set' and Apple's TCC daemon cannot pin a stable identity. Without
   a hint, the user assumes the wizard is broken when they go to
   System Settings looking for Jarvis.

Fixes:

- OnboardingWizardController.open():
    * If self.window already exists and is visible: makeKeyAndOrderFront +
      NSApp.activate; do NOT spawn a new window.
    * styleMask always [.titled, .closable, .miniaturizable] — the close
      button is now governed by an enable/disable helper rather than the
      style mask, so the chrome stays consistent.
    * Subscribe to state.objectWillChange (Combine) and re-run
      applyCloseButtonState whenever the wizard advances; the close
      button auto-enables once apiKey is stored.
    * applyCloseButtonState lock condition is now firstLaunch && stage ==
      .apiKey && !apiKeyStored — the moment the key lands in Keychain, the
      lock releases. Window level drops back to .normal too.

- WizardStageTCCView Input Monitoring row:
    * Added a 'Re-check' button after first probe so user can re-query
      after granting in System Settings without restarting the wizard.
    * Added a System-Settings helper card explaining what to do when the
      bundle isn't auto-listed (the macOS quirk for ad-hoc signed Debug
      builds): 'click + and choose Jarvis.app from your build folder'.
    * Granted check-mark wins over Re-check button — once granted, only
      the green ✓ shows.

Verified: check-app-builds clean. dev-reset.sh + relaunch puts wizard
at apiKey with close button correctly disabled; entering API key
re-enables close; advancing through stages keeps it enabled.
2026-05-02 07:41:15 -05:00
james.maesandClaude Opus 4.7 8ebdf76980 fix(hud): wrap text in wizard + banner instead of tail-truncation
Both the first-launch wizard's TCC stage and the HUD banner panel were
showing tail-truncated body text (Grant Permissions descriptions ending
in "...", Limited hotkey mode body cut at "The hotke..."). Two layered
SwiftUI layout bugs:

1. The body Text inside row HStacks (`VStack(title+body) + Spacer +
   button`) didn't have `.fixedSize(horizontal: false, vertical: true)`,
   so when the trailing button was wide ("Denied — Open System Settings")
   SwiftUI's HStack layout compressed Text and chose tail-truncation
   over multi-line wrap.

2. The wizard's outer frame was `560×440`, leaving only ~318h for
   stageBody after header(64) + dividers(2) + footer(56). The TCC stage
   with 4 permission rows needed ≥520h. The vertical squeeze cascaded
   into more aggressive Text compression and clipped the bottom Back row.

Fixes:
- WizardView: bump frame to 600×640.
- WizardStageTCCView: `.fixedSize(horizontal: false, vertical: true)` on
  description + each row's body. `.frame(maxWidth: .infinity, alignment:
  .leading)` on inner row VStacks so they receive the available width
  before the trailing button claims it. Spacer minLength bumped to 16
  for breathing room between body text and button.
- HUDBanner: same `.fixedSize` + `.frame(maxWidth:)` pair on the title
  +body VStack. The 360pt-wide banner needed it most because
  `HUDBannerPanel.positionTopTrailing` re-reads the SwiftUI fittingSize
  on host — without wrapping, the panel was sized to a single-line body
  and forced all subsequent body text to truncate.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-26 16:08:02 -05:00
james.maesandClaude Opus 4.7 ebefb91043 feat(01-04): build first-launch wizard + full AppDelegate launch wiring
- AnthropicKeyValidator: local sk-ant- prefix check + URLSession-injectable
  GET to api.anthropic.com/v1/models; returns typed enum, never logs key
- WizardState: @MainActor ObservableObject; D-09 stateless re-entry via
  refresh(); firstUnresolvedStage advances apiKey → tcc → hotkey → complete
- WizardStageAPIKeyView: SecureField, validator + Keychain round-trip; key
  value lives only in Keychain (SEC-01)
- WizardStageTCCView: Input Monitoring row actively probes; Mic/Camera/
  Automation rows are explainer-only (D-08/SEC-04); no permission APIs
  called from the view
- WizardStageHotkeyView: ShortcutRecorderView + CollisionDetector wiring;
  Skip leaves hotkey unbound (SHELL-02)
- WizardView: three-stage root with header dots + Back footer
- OnboardingWizardController: NSWindow hosting; first-launch .modalPanel
  + close-button disabled until API key stored (D-06)
- AppDelegate: full 8-step launch chain — logging bootstrap (S-8) →
  entitlement gate (Plan 03) → config load (NSAlert on malformed, D-19/S-6) →
  menu bar + HUD + banner install → Keychain fetch (.keychainEmpty banner
  on itemNotFound) → Input Monitoring probe (.inputMonitoringDenied banner
  on denial, SHELL-06) → HotkeyBinder init → Wizard open on first launch.
  copyStateDump writes boolean-only presence; API key VALUE never clipboarded
- JarvisApp: Settings scene stub; real NSPanels managed by AppDelegate
- Tests: 11 new (WizardState 4, AnthropicKeyValidator 3, WizardTCC 1,
  AppDelegateWiring 4) + updated AppDelegateEntitlementTests for the new
  launch chain; all 25 JarvisAppTests pass
- Re-inserted PBXCopyFilesBuildPhase for Contents/Helpers per Plan 01/03
  precedent (xcodegen strips empty copyFiles)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-22 14:07:04 -05:00