KofTwentyTwo/Jarvis
2
0 Fork 0
Code Issues 111 Pull Requests 16 Actions Packages Projects Releases 4 Wiki Activity

M-2: define JarvisAPI.Settings protocol + adapter wrapping ConfigStore #105

New Issue
Open
opened 2026-05-12 19:36:54 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-05-12 19:36:54 +00:00 (Migrated from github.com)
Copy link
Copy source

Goal

Define JarvisAPI.Settings protocol and implement adapter wrapping ConfigStore. getSettings query + settingsChanged event.

Scope

  • JarvisAPI.Settings protocol
  • SettingsState codable struct exposing all configurable fields
  • SettingsAdapter wraps ConfigStore.perTurn() + LaunchSnapshot
  • settingsChanged event emits with changed key paths

Files

  • packages/JarvisAPI/Sources/JarvisAPI/Surfaces/Settings.swift (new)
  • packages/JarvisAPI/Sources/JarvisAPI/Surfaces/Settings+Adapter.swift (new)

Acceptance

  • Protocol + adapter compile
  • getSettings() returns hydrated state from ConfigStore
  • settingsChanged event includes changedKeyPaths: [String]
  • getSettings.confirmationTimeoutSeconds field exposed (foreshadows R-008)

Test

Scenario stub S-SET-001 (round-trip getSettings) green in both transport modes.

Parent epic

#6

Source

.planning/architecture/JARVIS-API-MIGRATION-PLAN.md §2.3 (M-2.1)

## Goal Define JarvisAPI.Settings protocol and implement adapter wrapping ConfigStore. getSettings query + settingsChanged event. ## Scope - `JarvisAPI.Settings` protocol - `SettingsState` codable struct exposing all configurable fields - `SettingsAdapter` wraps `ConfigStore.perTurn()` + `LaunchSnapshot` - `settingsChanged` event emits with changed key paths ## Files - `packages/JarvisAPI/Sources/JarvisAPI/Surfaces/Settings.swift` (new) - `packages/JarvisAPI/Sources/JarvisAPI/Surfaces/Settings+Adapter.swift` (new) ## Acceptance - [ ] Protocol + adapter compile - [ ] `getSettings()` returns hydrated state from `ConfigStore` - [ ] `settingsChanged` event includes `changedKeyPaths: [String]` - [ ] `getSettings.confirmationTimeoutSeconds` field exposed (foreshadows R-008) ## Test Scenario stub `S-SET-001` (round-trip getSettings) green in both transport modes. ## Parent epic #6 ## Source `.planning/architecture/JARVIS-API-MIGRATION-PLAN.md` §2.3 (M-2.1)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area:agent
area:build
area:bus
area:devtool
area:hud
area:logging
area:mcp
area:memory
area:vision
area:voice
audit-finding
bug
Something isn't working
 carry-forward
comment-cleanup
Comment / docstring cleanup per .planning/code-commenting-guide.md
 dependencies
Dependency updates
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 epic
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 migration
question
Further information is requested
 severity:critical
severity:high
severity:low
severity:medium
wontfix
This will not be worked on
No labels area:build enhancement migration
Milestone
No items
No Milestone v0.5 — API M-0..M-3 (Self / Settings / Diagnostics surfaces)
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/Jarvis#105