KofTwentyTwo/Jarvis
2
0 Fork 0
Code Issues 111 Pull Requests 16 Actions Packages Projects Releases 4 Wiki Activity

M-4: Memory.forgetFact command (F-009 — no requiresConfirmation transport leak) #116

New Issue
Open
opened 2026-05-12 19:37:09 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-05-12 19:37:09 +00:00 (Migrated from github.com)
Copy link
Copy source

Goal

Implement Memory.forgetFact command. No requiresConfirmation param on the wire (F-009 transport leak); confirmation routed via ConfirmationBroker test seam under UQ-1 gate.

Scope

  • forgetFact(factId:) command
  • Confirmation flow: ConfirmationBroker requests user confirm (or auto-approves when setConfirmationDefault set via UQ-1)
  • No requiresConfirmation field exposed to client (F-009)

Files

  • packages/JarvisAPI/Sources/JarvisAPI/Surfaces/Memory+Adapter.swift
  • packages/MCP/Sources/MCP/ConfirmationBroker.swift integration

Acceptance

  • forgetFact requires confirmation in production
  • Harness setConfirmationDefault(.approve) auto-approves
  • No requiresConfirmation field in wire schema

Test

S-MEM-004 (forgetFact with auto-approve harness).

Parent epic

#8

Source

.planning/architecture/JARVIS-API-MIGRATION-PLAN.md §2.5 (M-4.2)
.planning/architecture/JARVIS-API-DESIGN-v0.2.md F-009

## Goal Implement Memory.forgetFact command. No requiresConfirmation param on the wire (F-009 transport leak); confirmation routed via ConfirmationBroker test seam under UQ-1 gate. ## Scope - `forgetFact(factId:)` command - Confirmation flow: `ConfirmationBroker` requests user confirm (or auto-approves when `setConfirmationDefault` set via UQ-1) - No `requiresConfirmation` field exposed to client (F-009) ## Files - `packages/JarvisAPI/Sources/JarvisAPI/Surfaces/Memory+Adapter.swift` - `packages/MCP/Sources/MCP/ConfirmationBroker.swift` integration ## Acceptance - [ ] `forgetFact` requires confirmation in production - [ ] Harness `setConfirmationDefault(.approve)` auto-approves - [ ] No `requiresConfirmation` field in wire schema ## Test `S-MEM-004` (forgetFact with auto-approve harness). ## Parent epic #8 ## Source `.planning/architecture/JARVIS-API-MIGRATION-PLAN.md` §2.5 (M-4.2) `.planning/architecture/JARVIS-API-DESIGN-v0.2.md` F-009
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area:agent
area:build
area:bus
area:devtool
area:hud
area:logging
area:mcp
area:memory
area:vision
area:voice
audit-finding
bug
Something isn't working
 carry-forward
comment-cleanup
Comment / docstring cleanup per .planning/code-commenting-guide.md
 dependencies
Dependency updates
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 epic
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 migration
question
Further information is requested
 severity:critical
severity:high
severity:low
severity:medium
wontfix
This will not be worked on
No labels area:memory enhancement migration
Milestone
No items
No Milestone v0.8 — API M-4..M-7 (Memory / Vision / Voice / Turn surfaces)
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/Jarvis#116