KofTwentyTwo/Jarvis
2
0 Fork 0
Code Issues 111 Pull Requests 16 Actions Packages Projects Releases 4 Wiki Activity

M-4: factMutated + factsRetrieved events; delete legacy emit (R-017) #117

New Issue
Open
opened 2026-05-12 19:37:10 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-05-12 19:37:10 +00:00 (Migrated from github.com)
Copy link
Copy source

Goal

Add Memory.factMutated + factsRetrieved events. REPLACE old replay-event emit; do NOT parallel-emit. Preserves R-017 single-emit invariant.

Scope

  • New events: factMutated(op:, factId:), factsRetrieved(count:, query:)
  • DELETE old emit site in MemoryStore.applyOp
  • Critical: do not parallel-emit (Failure Mode 1)

Files

  • packages/JarvisAPI/Sources/JarvisAPI/Surfaces/Memory+Adapter.swift
  • packages/Memory/Sources/Memory/MemoryStore.swift — DELETE legacy replay emit

Acceptance

  • bash scripts/check-single-memory-mutated-emit.sh green AFTER migration
  • bash scripts/check-single-memory-used-emit.sh green
  • Old emit site DELETED (grep confirms)
  • Behavioral assertion: one fact write = one event + one replay row

Test

S-MEM-005 asserts single-emit invariant.

Parent epic

#8

Source

.planning/architecture/JARVIS-API-MIGRATION-PLAN.md §2.5 (M-4.3) + §5.1 Failure Mode 1
.planning/architecture/REVIEW-MIGRATION-RISK.md R-017

## Goal Add Memory.factMutated + factsRetrieved events. REPLACE old replay-event emit; do NOT parallel-emit. Preserves R-017 single-emit invariant. ## Scope - New events: `factMutated(op:, factId:)`, `factsRetrieved(count:, query:)` - DELETE old emit site in `MemoryStore.applyOp` - Critical: do not parallel-emit (Failure Mode 1) ## Files - `packages/JarvisAPI/Sources/JarvisAPI/Surfaces/Memory+Adapter.swift` - `packages/Memory/Sources/Memory/MemoryStore.swift` — DELETE legacy replay emit ## Acceptance - [ ] `bash scripts/check-single-memory-mutated-emit.sh` green AFTER migration - [ ] `bash scripts/check-single-memory-used-emit.sh` green - [ ] Old emit site DELETED (grep confirms) - [ ] Behavioral assertion: one fact write = one event + one replay row ## Test `S-MEM-005` asserts single-emit invariant. ## Parent epic #8 ## Source `.planning/architecture/JARVIS-API-MIGRATION-PLAN.md` §2.5 (M-4.3) + §5.1 Failure Mode 1 `.planning/architecture/REVIEW-MIGRATION-RISK.md` R-017
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area:agent
area:build
area:bus
area:devtool
area:hud
area:logging
area:mcp
area:memory
area:vision
area:voice
audit-finding
bug
Something isn't working
 carry-forward
comment-cleanup
Comment / docstring cleanup per .planning/code-commenting-guide.md
 dependencies
Dependency updates
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 epic
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 migration
question
Further information is requested
 severity:critical
severity:high
severity:low
severity:medium
wontfix
This will not be worked on
No labels area:memory enhancement migration
Milestone
No items
No Milestone v0.8 — API M-4..M-7 (Memory / Vision / Voice / Turn surfaces)
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/Jarvis#117