KofTwentyTwo/Jarvis
2
0 Fork 0
Code Issues 111 Pull Requests 16 Actions Packages Projects Releases 4 Wiki Activity

M-7: ConfirmationBroker reads timeout from ConfirmationPolicy (R-008, F-013) #138

New Issue
Open
opened 2026-05-12 19:37:37 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-05-12 19:37:37 +00:00 (Migrated from github.com)
Copy link
Copy source

Goal

MCP ConfirmationBroker reads timeout from injected ConfirmationPolicy (R-008). Resolves R-008 — was hardcoded 60s. Harness asserts configured timeout respected. ConfirmationOutcome collapses to single enum (F-013).

Scope

  • ConfirmationBroker accepts ConfirmationPolicy (timeout, default)
  • Timeout read from Settings.getSettings().confirmationTimeoutSeconds
  • ConfirmationOutcome is single enum (no duplicate types per F-013)

Files

  • packages/MCP/Sources/MCP/ConfirmationBroker.swift

Acceptance

  • Timeout configurable (no hardcoded 60s)
  • Harness asserts configured timeout respected (e.g., 5s setting → 5s expiry)
  • ConfirmationOutcome collapsed to single enum
  • R-008 closed

Test

S-TURN-015 asserts timeout respected (set 2s; expect timeout at 2s).

Parent epic

#11

Source

.planning/architecture/JARVIS-API-MIGRATION-PLAN.md §2.8 (M-7.4)
.planning/architecture/JARVIS-API-DESIGN-v0.2.md F-013
.planning/architecture/REVIEW-MIGRATION-RISK.md R-008

## Goal MCP ConfirmationBroker reads timeout from injected ConfirmationPolicy (R-008). Resolves R-008 — was hardcoded 60s. Harness asserts configured timeout respected. ConfirmationOutcome collapses to single enum (F-013). ## Scope - `ConfirmationBroker` accepts `ConfirmationPolicy` (timeout, default) - Timeout read from `Settings.getSettings().confirmationTimeoutSeconds` - `ConfirmationOutcome` is single enum (no duplicate types per F-013) ## Files - `packages/MCP/Sources/MCP/ConfirmationBroker.swift` ## Acceptance - [ ] Timeout configurable (no hardcoded 60s) - [ ] Harness asserts configured timeout respected (e.g., 5s setting → 5s expiry) - [ ] `ConfirmationOutcome` collapsed to single enum - [ ] R-008 closed ## Test `S-TURN-015` asserts timeout respected (set 2s; expect timeout at 2s). ## Parent epic #11 ## Source `.planning/architecture/JARVIS-API-MIGRATION-PLAN.md` §2.8 (M-7.4) `.planning/architecture/JARVIS-API-DESIGN-v0.2.md` F-013 `.planning/architecture/REVIEW-MIGRATION-RISK.md` R-008
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area:agent
area:build
area:bus
area:devtool
area:hud
area:logging
area:mcp
area:memory
area:vision
area:voice
audit-finding
bug
Something isn't working
 carry-forward
comment-cleanup
Comment / docstring cleanup per .planning/code-commenting-guide.md
 dependencies
Dependency updates
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 epic
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 migration
question
Further information is requested
 severity:critical
severity:high
severity:low
severity:medium
wontfix
This will not be worked on
No labels area:mcp enhancement migration
Milestone
No items
No Milestone v0.8 — API M-4..M-7 (Memory / Vision / Voice / Turn surfaces)
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/Jarvis#138