KofTwentyTwo/Jarvis
2
0 Fork 0
Code Issues 111 Pull Requests 16 Actions Packages Projects Releases 4 Wiki Activity

FrameAttachController leaks pendingFrame on .rejected submit — D-15 byte-release window violated #2

New Issue
Closed
opened 2026-05-12 18:57:39 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-05-12 18:57:39 +00:00 (Migrated from github.com)
Copy link
Copy source

Summary

FrameAttachController.confirmSend(userText:) doesn't release pendingFrame when the user submits but the orchestrator returns .rejected. JPEG bytes persist past the D-15 byte-release window — memory leak per pending frame that gets rejected.

Evidence

  • App/Vision/AppDelegateFrameAttachAdapters.swift (around the rejected-submit path)
  • D-15 invariant: frame bytes released within the configured window after submit.

Recommended fix

In the .rejected branch of handleChatSubmit / handleChatCancelAndSubmit, explicitly call frameAttachController.releasePendingFrame() (or equivalent) before returning.

Source

Audit .planning/audit-2026-05-12/vision-audit.md (2026-05-12)

## Summary `FrameAttachController.confirmSend(userText:)` doesn't release `pendingFrame` when the user submits but the orchestrator returns `.rejected`. JPEG bytes persist past the D-15 byte-release window — memory leak per pending frame that gets rejected. ## Evidence - `App/Vision/AppDelegateFrameAttachAdapters.swift` (around the rejected-submit path) - D-15 invariant: frame bytes released within the configured window after submit. ## Recommended fix In the `.rejected` branch of `handleChatSubmit` / `handleChatCancelAndSubmit`, explicitly call `frameAttachController.releasePendingFrame()` (or equivalent) before returning. ## Source Audit `.planning/audit-2026-05-12/vision-audit.md` (2026-05-12)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area:agent
area:build
area:bus
area:devtool
area:hud
area:logging
area:mcp
area:memory
area:vision
area:voice
audit-finding
bug
Something isn't working
 carry-forward
comment-cleanup
Comment / docstring cleanup per .planning/code-commenting-guide.md
 dependencies
Dependency updates
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 epic
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 migration
question
Further information is requested
 severity:critical
severity:high
severity:low
severity:medium
wontfix
This will not be worked on
No labels area:vision audit-finding bug severity:medium
Milestone
No items
No Milestone v0.1 — It actually works (basic capabilities)
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/Jarvis#2