KofTwentyTwo/Jarvis
2
0 Fork 0
Code Issues 111 Pull Requests 16 Actions Packages Projects Releases 4 Wiki Activity

Voice: whisperKitFallback feature flag is test-quality dead code #39

New Issue
Open
opened 2026-05-12 19:07:26 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-05-12 19:07:26 +00:00 (Migrated from github.com)
Copy link
Copy source

Summary

STTConfig.whisperKitFallback: Bool exists and default-config.json sets it false. Even if a user flips it, the hard-coded factory at AppDelegate.swift:1272 ignores it. The flag appears in PerTurnSnapshot because the config-to-snapshot pipeline is generic, but no production consumer exists.

Evidence

  • File: packages/Config/Sources/Config/STTConfig.swift
  • File: App/AppDelegate.swift:1272 (hard-coded factory)

Recommended fix

Closed naturally by #29 (P0-2) — fix the hard-coded factory to read from config.

Source

  • Audit: .planning/audit-2026-05-12/voice-audit.md (2026-05-12) — finding P2-3

Cross-references

  • Closed by: #29 (P0-2)
## Summary `STTConfig.whisperKitFallback: Bool` exists and `default-config.json` sets it `false`. Even if a user flips it, the hard-coded factory at `AppDelegate.swift:1272` ignores it. The flag appears in `PerTurnSnapshot` because the config-to-snapshot pipeline is generic, but no production consumer exists. ## Evidence - File: `packages/Config/Sources/Config/STTConfig.swift` - File: `App/AppDelegate.swift:1272` (hard-coded factory) ## Recommended fix Closed naturally by #29 (P0-2) — fix the hard-coded factory to read from config. ## Source - Audit: `.planning/audit-2026-05-12/voice-audit.md` (2026-05-12) — finding P2-3 ## Cross-references - Closed by: #29 (P0-2)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area:agent
area:build
area:bus
area:devtool
area:hud
area:logging
area:mcp
area:memory
area:vision
area:voice
audit-finding
bug
Something isn't working
 carry-forward
comment-cleanup
Comment / docstring cleanup per .planning/code-commenting-guide.md
 dependencies
Dependency updates
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 epic
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 migration
question
Further information is requested
 severity:critical
severity:high
severity:low
severity:medium
wontfix
This will not be worked on
No labels area:voice audit-finding bug severity:low
Milestone
No items
No Milestone v0.2 — Observable + stable (audit punch-list)
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/Jarvis#39