KofTwentyTwo/Jarvis
2
0 Fork 0
Code Issues 111 Pull Requests 16 Actions Packages Projects Releases 4 Wiki Activity

PTT (VOICE-13) is dead — hotkey unbound at launch; pttDown/pttUp never reach VoiceController #87

New Issue
Closed
opened 2026-05-12 19:31:26 +00:00 by KofTwentyTwo · 1 comment
KofTwentyTwo commented 2026-05-12 19:31:26 +00:00 (Migrated from github.com)
Copy link
Copy source

Summary

The push-to-talk path is fully implemented but completely unwired in production. `VoiceController.pttDown()` / `pttUp()` are public actor methods, `PushToTalk.bind(keyCode:)` exists in `packages/Voice/Sources/Voice/Control/PushToTalk.swift`, but `App/AppDelegate.swift:1015` doesn't bind a PTT key at launch — the hotkey slot is empty and the actor never receives a press event.

VOICE-13 is a v1 requirement: "Push-to-talk variant: hold-to-talk hotkey pathway activates STT without wake word (privacy / reliability fallback for wake-word false-negatives)."

Evidence

  • `packages/Voice/Sources/Voice/VoiceController.swift:190` — `pttDown()` DEAD
  • `packages/Voice/Sources/Voice/VoiceController.swift:206` — `pttUp()` DEAD
  • `packages/Voice/Sources/Voice/Control/PushToTalk.swift:43,58,114,125` — `PushToTalk.bind / unbind` DEAD
  • `App/AppDelegate.swift:1015` — PTT remains unbound at launch
  • INVENTORY.md:116-117, 143 — all three marked DEAD
  • REQUIREMENTS.md VOICE-13

Gap classification

"working but not wired" — implementation is correct; the production caller / hotkey registration doesn't exist.

Recommended action

File standalone (no M-phase; this is a v1 requirement that slipped). Pattern:

  1. Add a default PTT hotkey to first-launch wizard (or default-config.json with a safe combo).
  2. Wire `PushToTalk.bind(keyCode:)` in `installVoice` against the configured key.
  3. Route `PushToTalk` events to `voiceController.pttDown()` / `pttUp()` via the existing actor seam.

Cross-references

  • REQUIREMENTS.md VOICE-13 (Pending)
  • INVENTORY.md §Voice
  • Related: #28 (wake-word path) — but PTT is independent
## Summary The push-to-talk path is fully implemented but completely unwired in production. \`VoiceController.pttDown()\` / \`pttUp()\` are public actor methods, \`PushToTalk.bind(keyCode:)\` exists in \`packages/Voice/Sources/Voice/Control/PushToTalk.swift\`, but \`App/AppDelegate.swift:1015\` doesn't bind a PTT key at launch — the hotkey slot is empty and the actor never receives a press event. VOICE-13 is a v1 requirement: \"Push-to-talk variant: hold-to-talk hotkey pathway activates STT without wake word (privacy / reliability fallback for wake-word false-negatives).\" ## Evidence - \`packages/Voice/Sources/Voice/VoiceController.swift:190\` — \`pttDown()\` DEAD - \`packages/Voice/Sources/Voice/VoiceController.swift:206\` — \`pttUp()\` DEAD - \`packages/Voice/Sources/Voice/Control/PushToTalk.swift:43,58,114,125\` — \`PushToTalk.bind / unbind\` DEAD - \`App/AppDelegate.swift:1015\` — PTT remains unbound at launch - INVENTORY.md:116-117, 143 — all three marked DEAD - REQUIREMENTS.md VOICE-13 ## Gap classification \"working but not wired\" — implementation is correct; the production caller / hotkey registration doesn't exist. ## Recommended action File standalone (no M-phase; this is a v1 requirement that slipped). Pattern: 1. Add a default PTT hotkey to first-launch wizard (or default-config.json with a safe combo). 2. Wire \`PushToTalk.bind(keyCode:)\` in \`installVoice\` against the configured key. 3. Route \`PushToTalk\` events to \`voiceController.pttDown()\` / \`pttUp()\` via the existing actor seam. ## Cross-references - REQUIREMENTS.md VOICE-13 (Pending) - INVENTORY.md §Voice - Related: #28 (wake-word path) — but PTT is independent
KofTwentyTwo commented 2026-05-13 11:52:14 +00:00 (Migrated from github.com)
Copy link
Copy source

Closed by v0.1 cluster merges on 2026-05-13. Develop now at a8c7f1a0.

Closed by v0.1 cluster merges on 2026-05-13. Develop now at `a8c7f1a0`.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area:agent
area:build
area:bus
area:devtool
area:hud
area:logging
area:mcp
area:memory
area:vision
area:voice
audit-finding
bug
Something isn't working
 carry-forward
comment-cleanup
Comment / docstring cleanup per .planning/code-commenting-guide.md
 dependencies
Dependency updates
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 epic
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 migration
question
Further information is requested
 severity:critical
severity:high
severity:low
severity:medium
wontfix
This will not be worked on
No labels area:agent area:voice bug severity:medium
Milestone
No items
No Milestone v0.2 — Observable + stable (audit punch-list)
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/Jarvis#87