From 10782d633302b127e4f7f97b2797c7055d07f7e7 Mon Sep 17 00:00:00 2001 From: James Maes Date: Wed, 13 May 2026 07:37:26 -0500 Subject: [PATCH] ci(actions): make Typecheck step blocking PR #165 fixed the one real strict-undefined error in SegmentedRing.tsx; the other ~30 errors reported in CI run 25797533005 were downstream of `TS2307: Cannot find module '@jarvis/bus'` and resolve automatically once `scripts/build-webview.sh` produces the bus package's `dist/index.d.ts` (which CI already runs before typecheck). Removes `continue-on-error: true` from the Typecheck step so typecheck regressions block CI going forward. Co-Authored-By: Claude Opus 4.7 --- .github/workflows/ci.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c11f5bf..927e36e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -94,14 +94,13 @@ jobs: # both find a working HUD bundle. - name: Build HUD bundle (produces @jarvis/bus dist + App/Resources/webview/) run: bash scripts/build-webview.sh - # Typecheck currently surfaces ~30 pre-existing strict-undefined errors - # (TS18048) in src/hud/{CoreGlow,Reticle,RingMesh,SegmentedRing}.tsx and - # related files. These are real but pre-existed and were masked because - # only vitest ran locally — not `tsc --noEmit`. Marked `continue-on-error` - # until the focused cleanup PR lands. See v0.2 issue for the cleanup. - - name: Typecheck (non-blocking until v0.2 strict-undefined cleanup) + # Typecheck is blocking. The historical ~30 errors reported in CI run + # 25797533005 were almost entirely downstream of `TS2307: Cannot find + # module '@jarvis/bus'` and disappear once `build-webview.sh` runs above + # (which produces `packages/bus/dist/index.d.ts`). The one real strict- + # undefined error in SegmentedRing.tsx was fixed in PR #165. + - name: Typecheck working-directory: webview - continue-on-error: true run: pnpm -r typecheck - name: Test (vitest) working-directory: webview -- 2.54.0