fix(print): show the system print dialog and widen print options #22
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: KofTwentyTwo/MarkdownViewr.Windows#22
Reference in new issue
Block a user
Owner-reported bug in the current local development build: File → Print opens our options dialog, but choosing Print… does not visibly show the Windows system print dialog. The options dialog is also too narrow.
Acceptance:
Current implementation calls CoreWebView2.ShowPrintUI(System) after installing print CSS. The spooler is running and the current activity log has no print exception; root cause not yet established. Earlier hosted print acceptance does not disprove this local report. Related: #12, #1.
Substantial AI assistance: Codex (GPT-6).
Local progress: Print options now have a wider responsive native layout, and a compiled actual-width assertion was added. Print phase/preparation/runtime diagnostics are in place. The system-print handoff still uses the official ShowPrintUI(System) API; its void return is not treated as proof that a dialog appeared. Running Debug app/logs show no recorded print exception; spooler is running. The cause of the owner’s missing-dialog report remains unproven. New code builds0warnings/errors; GUI reproduction awaits the existing desktop-reservation answer. Do not close this ticket.
Signed/DCO commit05bf612 is pushed to feat/windows-viewer/PR#3. It fixes the full-page outer body width reset, aligns Contents/Print with the other48px toolbar hit targets, uses the observed exact Open picker filename field1148 and tests the actual outline-depth control. Pixel checks sample the owned WebView; native width/scroll/font assertions are unchanged and now retain precise failure evidence. No cases are skipped.
Local gates: zero-warning Release build,586 core tests,100% measured core line coverage, full formatting and all commit/security/workflow hooks pass. Exact prior CI38166230860: source-hover passes; full native74/97,23failures,0skips; published suite exceeds600seconds before installed outcomes. A focused hosted reader-regressions job now covers these current paths alongside the full suite. Native/distributed/signature/review/release acceptance is still pending; no production release published.
Owner preview PID55472 remains responsive and untouched. Its portable output predates the latest candidate fixes. Existing Azure setup is preserved; precise repository-specific verification, immutable OIDC trust and profile-scoped role commands are in docs/azure-signing-admin.md, with no Azure mutations performed.
Exact
bd3d72a/ CI38180868496 is terminal. Full native99/99 and focused21/21 pass, zero skips. Published suite exceeds the unchanged600-second process bound with no final TRX. Actual retained process-15.log reports initial30-second heading waits failing in Print_KeyboardDraftCancel and Print_WindowsDialogCancel, before either Print action. Later screenshots/PDFs prove other cases continued; no installed lifecycle result is inferred.Signed/DCO
53755abis pushed after retaining the terminal artifacts. It adds per-case console progress to unchanged full published/installed suites and owned activity-log/screenshot/accessibility-tree capture only on those print startup failures. This will distinguish missing document activation/render readiness, a blocked individual case, suite duration or shutdown. No production fix is claimed, and no cases, assertions or deadlines are changed.Local zero-warning Release/format,17 relevant tooling tests, all configured analyzer rules and shared Markdown lint pass. The push also includes signed coexistence acceptance5de4125 and immutable rendering audit489af75; actual coexistence remains unexecuted. Fresh hosted gates are pending; no local desktop input, production signing or release.
Signed/DCO local7fa9f77 adds a dedicated native Printing page with a shared PrintOptionsEditor used by the output dialog: themes, backgrounds/images, font zoom, width, borders and bounded padding. Apply saves validated defaults; Restore uses the latest saved baseline; closing discards drafts. PDF destinations and Open PDF/Open folder remain deliberate export actions. Checked saves precede shared reader-baseline broadcasts, preserving unsubmitted sibling Settings drafts. Theme changes refresh available named print choices; native navigation labels stay visible at normal width.
Zero-warning/error Release build and formatting pass; all598 core tests/100% measured lines pass.102 native cases compile/discover, including new actual Apply/Restore/Print-cancel/persistence and concurrent sibling-output/draft/Restore checks, with owned controls and a real Settings screenshot. Existing Print/PDF/pixel checks and every deadline remain unchanged. New native assertions are not yet executed; no local input occurred.
Exact pushedb5e519e focused19/22 and full native98/100 fail, zero skips. The new Contents options case passes in both. Localec78b50 corrects actual raw-inline/HTML-block closing boundaries, tooltip click interception and an observed exact picker lookup problem;598 core cases prove the reproduced parser correction. Installed114603470178 is still live, so these commits are held to preserve the full run. Retained focused/full logs and actual TRX/Settings pixels under artifacts/reader-regressions-38184378762. Full theme/default-status design, fresh acceptance, owner review and production signing remain open.