feat(about): link all components and move upstream credits into Contributions #24

Open
opened 2026-10-11 14:13:26 +00:00 by KofTwentyTwo · 3 comments
KofTwentyTwo commented 2026-10-11 14:13:26 +00:00 (Migrated from github.com)

Owner request

Expand About so every component/open-source library is identified and linked to its official project and license where available. Move the original macOS viewer attribution and Darin Kelkhoff’s repository/website links into a Contributions section, below the normal application header; remove the extra attribution block at the top.

Acceptance

  • Retain AppKit’s application brand, version and license information.
  • Contributions credits Darin’s original macOS viewer, copyright/MIT license, repository and website.
  • Components individually list the actual shipped direct/transitive libraries, with official project/license links; identify development tooling separately.
  • Validate inventory against actual dependency assets and retain shipped notices.
  • Native keyboard-accessible links and scrolling work at normal Windows display scaling.
  • Record actual checks and desktop acceptance without claiming unrun tests.

Related: #19. Substantial implementation assistance by Codex (GPT-6).

## Owner request Expand About so every component/open-source library is identified and linked to its official project and license where available. Move the original macOS viewer attribution and Darin Kelkhoff’s repository/website links into a Contributions section, below the normal application header; remove the extra attribution block at the top. ## Acceptance - Retain AppKit’s application brand, version and license information. - Contributions credits Darin’s original macOS viewer, copyright/MIT license, repository and website. - Components individually list the actual shipped direct/transitive libraries, with official project/license links; identify development tooling separately. - Validate inventory against actual dependency assets and retain shipped notices. - Native keyboard-accessible links and scrolling work at normal Windows display scaling. - Record actual checks and desktop acceptance without claiming unrun tests. Related: #19. Substantial implementation assistance by Codex (GPT-6).
KofTwentyTwo commented 2026-10-11 14:40:16 +00:00 (Migrated from github.com)

Implemented locally: Darin’s credit/repository/site/license links are now in Contributions below AppKit’s normal header/license. About Components individually links23 application/platform and29 development dependencies to official project/license destinations. An independent regression compares names/versions against actual restored assets, including transitive packages. Microsoft binary license terms are identified separately from MIT. Eleven distinct packaged SDK/WebView/tensor license/notice texts are retained verbatim and all copied review-output bytes match. Full Release build has zero warnings/errors;570 core tests/100% measured lines pass. Actual About scrolling/keyboard-link acceptance is prepared, not run. New review window: Review-latest.md. Signed commit/push remains pending1Password authentication.

Implemented locally: Darin’s credit/repository/site/license links are now in Contributions below AppKit’s normal header/license. About Components individually links23 application/platform and29 development dependencies to official project/license destinations. An independent regression compares names/versions against actual restored assets, including transitive packages. Microsoft binary license terms are identified separately from MIT. Eleven distinct packaged SDK/WebView/tensor license/notice texts are retained verbatim and all copied review-output bytes match. Full Release build has zero warnings/errors;570 core tests/100% measured lines pass. Actual About scrolling/keyboard-link acceptance is prepared, not run. New review window: Review-latest.md. Signed commit/push remains pending1Password authentication.
KofTwentyTwo commented 2026-10-11 15:05:39 +00:00 (Migrated from github.com)

The earlier preview startup failure was corrected and the newest review successfully opens. The linked About inventory/Contributions implementation remains available for owner review. Actual About placement/links and exact distributed packaging acceptance remain pending.

Fresh owner preview: Review-toolbar-splash.md — MarkdownViewr, PID103040, output artifacts/splash-toolbar-review/bin/x64/Release/net10.0-windows10.0.19041.0/MarkdownViewr.Windows.exe. Its separate review profile enables a5000ms splash and Source, and disables startup update checks. Other owner windows were preserved.

Verification: zero-warning/error full Release build;570 core tests pass,100% measured line coverage; formatting and changed-doc lint pass.79 UI-project cases discovered (66desktop/13filesystem; expected78 per installed channel); actual new desktop/distributed acceptance has not run. Launch/document opening succeeded with no warnings in the profile log. Passive Computer Use inspection was unavailable because its native pipe was not found; no mouse/keyboard input occurred.

The original four staged corrections remain unchanged. Signed commits/push still await the pending1Password ready reply; no signing retry, merge, tag, release or Azure change. System Print handoff, PDF open actions, remaining full PRODUCT parity, standards and exact production-signature proof remain open.

The earlier preview startup failure was corrected and the newest review successfully opens. The linked About inventory/Contributions implementation remains available for owner review. Actual About placement/links and exact distributed packaging acceptance remain pending. Fresh owner preview: `Review-toolbar-splash.md — MarkdownViewr`, PID103040, output `artifacts/splash-toolbar-review/bin/x64/Release/net10.0-windows10.0.19041.0/MarkdownViewr.Windows.exe`. Its separate review profile enables a5000ms splash and Source, and disables startup update checks. Other owner windows were preserved. Verification: zero-warning/error full Release build;570 core tests pass,100% measured line coverage; formatting and changed-doc lint pass.79 UI-project cases discovered (66desktop/13filesystem; expected78 per installed channel); actual new desktop/distributed acceptance has not run. Launch/document opening succeeded with no warnings in the profile log. Passive Computer Use inspection was unavailable because its native pipe was not found; no mouse/keyboard input occurred. The original four staged corrections remain unchanged. Signed commits/push still await the pending1Password ready reply; no signing retry, merge, tag, release or Azure change. System Print handoff, PDF open actions, remaining full PRODUCT parity, standards and exact production-signature proof remain open.
KofTwentyTwo commented 2026-10-11 16:33:35 +00:00 (Migrated from github.com)

Owner review clarification — 2026-10-11

About → Components should be a focused open-source acknowledgements list: actual shipped open-source libraries and dependencies, their authors/projects, and project/license links. Remove the general build/development-tool inventory and generic platform/service credits from this user-facing tab. This supersedes the earlier instruction to identify development tools there.

Preserve the audited dependency inventory and all required distributed copyright/license/notice texts. Do not remove acknowledgements required by a bundled dependency's license. Keep Darin Kelkhoff's original macOS app, repository, website and MIT attribution in Contributions, below the normal app header.

Verify the revised tab against the actual shipped dependencies and exercise its accessible links/scrolling. Recorded as pending during paused review; no new implementation or acceptance claim.

## Owner review clarification — 2026-10-11 About → Components should be a focused open-source acknowledgements list: actual shipped open-source libraries and dependencies, their authors/projects, and project/license links. Remove the general build/development-tool inventory and generic platform/service credits from this user-facing tab. This supersedes the earlier instruction to identify development tools there. Preserve the audited dependency inventory and all required distributed copyright/license/notice texts. Do not remove acknowledgements required by a bundled dependency's license. Keep Darin Kelkhoff's original macOS app, repository, website and MIT attribution in Contributions, below the normal app header. Verify the revised tab against the actual shipped dependencies and exercise its accessible links/scrolling. Recorded as pending during paused review; no new implementation or acceptance claim.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/MarkdownViewr.Windows#24