build: pin SDK 10.0.401, the version the committed lock files require #44

Merged

forge-recovery merged 1 commits from ci/sdk-pin-matches-locks into main 2026-11-01 22:46:07 +00:00

Conversation 0 Commits 1 Files Changed 1

+1 -1

forge-recovery commented 2026-11-01 22:19:47 +00:00

Owner

Copy link

Copy source

One-line change: global.json SDK 10.0.100 -> 10.0.401.

Why (existing build blocked)

The committed packages.lock.json files require Microsoft.NET.ILLink.Tasks 10.0.12, which is what SDK 10.0.401 resolves. The pin said 10.0.100,
so the existing dotnet restore MarkdownViewr.Windows.slnx -p:Platform=x64 --locked-mode step fails with NU1004 both under exactly 10.0.100 and
under a newer 10.0.4xx (the native Windows runner has 10.0.403). rollForward: latestFeature had been hiding this on GitHub's windows-latest
image. setup-dotnet will now install the SDK the locks were generated with.

Verified (real run, Windows host, central engine script dotnet-verify.ps1, exact SDK 10.0.401, no source change beyond this file)

• locked restore, -warnaserror build, dotnet format --verify-no-changes (with the WinUI app project built first, as the existing
  format-projects input does for AppKit)
• MarkdownViewr.Windows.Core.Tests: 677 passed of 677, 0 skipped
• line coverage MarkdownViewr.Windows.Core: 100%
• legacy Node job commands (scripts.yml): npm ci --ignore-scripts, npm run lint, npm test (8 of 8, 0 skipped), npm audit signatures all pass

Not covered by that run (unchanged, not hidden)

UI suites (reader-regressions, UiTests, need an interactive desktop), installed-updates, the powershell job in scripts.yml.

Co-Authored-By: Claude Sonnet 5.5 noreply@anthropic.com

One-line change: `global.json` SDK `10.0.100` -> `10.0.401`. ## Why (existing build blocked) The committed `packages.lock.json` files require `Microsoft.NET.ILLink.Tasks` 10.0.12, which is what SDK 10.0.401 resolves. The pin said 10.0.100, so the existing `dotnet restore MarkdownViewr.Windows.slnx -p:Platform=x64 --locked-mode` step fails with NU1004 both under exactly 10.0.100 and under a newer 10.0.4xx (the native Windows runner has 10.0.403). `rollForward: latestFeature` had been hiding this on GitHub's `windows-latest` image. `setup-dotnet` will now install the SDK the locks were generated with. ## Verified (real run, Windows host, central engine script `dotnet-verify.ps1`, exact SDK 10.0.401, no source change beyond this file) - locked restore, `-warnaserror` build, `dotnet format --verify-no-changes` (with the WinUI app project built first, as the existing `format-projects` input does for AppKit) - `MarkdownViewr.Windows.Core.Tests`: 677 passed of 677, 0 skipped - line coverage `MarkdownViewr.Windows.Core`: 100% - legacy Node job commands (`scripts.yml`): `npm ci --ignore-scripts`, `npm run lint`, `npm test` (8 of 8, 0 skipped), `npm audit signatures` all pass ## Not covered by that run (unchanged, not hidden) UI suites (`reader-regressions`, `UiTests`, need an interactive desktop), `installed-updates`, the `powershell` job in `scripts.yml`. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

forge-recovery added 1 commit 2026-11-01 22:19:47 +00:00

build: pin the SDK that the committed lock files were generated with ... 5c51c84ed1

global.json pinned 10.0.100, but every packages.lock.json requires Microsoft.NET.ILLink.Tasks 10.0.12 (what SDK 10.0.401 resolves). Under exactly 10.0.100, or under a newer 10.0.4xx such as 10.0.403, locked restore fails NU1004 ('package reference ... has changed from [10.0.12, ) to ...'). rollForward latestFeature hid this on GitHub's windows-latest runner image. Pinning 10.0.401 makes the existing restore --locked-mode, build, format and test steps reproducible; no other file or setting changes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

forge-recovery closed this pull request 2026-11-01 22:26:07 +00:00

forge-recovery reopened this pull request 2026-11-01 22:26:08 +00:00

forge-recovery merged commit 2e940d078a into main 2026-11-01 22:46:07 +00:00

forge-recovery referenced this pull request from KofTwentyTwo/windows-app-template 2026-11-01 22:46:42 +00:00

build: pin SDK 10.0.401, the version the committed lock files require #8

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

accessibility

Barrier affecting people with disabilities

bug

Something isn't working

deferred

Explicitly deferred work

dependencies

Pull requests that update a dependency file

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

github_actions

Pull requests that update GitHub Actions code

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

javascript

Pull requests that update javascript code

quality

Testing, reliability, and maintainability

question

Further information is requested

refactor

Internal changes without intended behavior changes

release

Packaging, signing, and release delivery

wontfix

This will not be worked on

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

forge-recovery (Forge Recovery) james.maes (James Maes)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KofTwentyTwo/MarkdownViewr.Windows#44