fix(activation): always open the launched document and start without the inbox when it is unavailable #52

New Issue

2026-11-10T23:50:16Z

james.maes commented

2026-11-10 23:50:16 +00:00

Problem

Starting a second copy of the reader hands its documents to the copy that is already running, through a per-user named pipe. Three defects on main (8763ff3), from the security, engine and shell reviews:

The reader creates its pipe outside any error handling and before the crash handler exists. If the pipe name is unavailable the reader does not start. Detail is in the private audit ledger until released.
A launch whose request the running reader does not take (it is shutting down, busy, or not listening) exits with code 1 and no window: the double-clicked file never opens.
One argument that cannot name a document (an empty string, a NUL character) discards every other document in the same launch.

The request, schema and inbox also live in the WinUI project, outside the coverage gate, and the Gitea workflow never runs their tests. A mutation run found that removing the frame bound, the read deadline, the queue bound or the sender's validation left every test green.

Expected

A reader that cannot create its inbox still starts.
A launch always opens its documents: in the running reader when it takes them, otherwise in its own window.
Unusable arguments are reported; the usable ones open.
The activation code is in the core library with deterministic tests for each bound and deadline.

## Problem Starting a second copy of the reader hands its documents to the copy that is already running, through a per-user named pipe. Three defects on `main` (8763ff3), from the security, engine and shell reviews: - The reader creates its pipe outside any error handling and before the crash handler exists. If the pipe name is unavailable the reader does not start. Detail is in the private audit ledger until released. - A launch whose request the running reader does not take (it is shutting down, busy, or not listening) exits with code 1 and no window: the double-clicked file never opens. - One argument that cannot name a document (an empty string, a NUL character) discards every other document in the same launch. The request, schema and inbox also live in the WinUI project, outside the coverage gate, and the Gitea workflow never runs their tests. A mutation run found that removing the frame bound, the read deadline, the queue bound or the sender's validation left every test green. ## Expected - A reader that cannot create its inbox still starts. - A launch always opens its documents: in the running reader when it takes them, otherwise in its own window. - Unusable arguments are reported; the usable ones open. - The activation code is in the core library with deterministic tests for each bound and deadline.

james.maes added the bug label 2026-11-10 23:50:16 +00:00

james.maes referenced this issue from a commit

2026-11-10 23:52:02 +00:00

fix(activation): always open the launched document and start without the inbox when it is unavailable

james.maes referenced a pull request that will close this issue

2026-11-10 23:52:02 +00:00

fix(activation): always open the launched document and start without the inbox when it is unavailable #53

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KofTwentyTwo/MarkdownViewr.Windows#52