feat(frontmatter): support hidden metadata and Markdown modes #8
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: KofTwentyTwo/MarkdownViewr.Windows#8
Reference in new issue
Block a user
Implement the pinned reference's three frontmatter modes: hide by default, show its line-based metadata table, or render the block as Markdown. Recognize the opening/closing --- delimiters without mistaking an unterminated thematic break for metadata. Preserve Windows CRLF and body content. Metadata keys/values are escaped; Markdown mode passes through the existing sanitizer. Persist the choice using AppKit and apply it to the active document/reloads.
Acceptance: bounded parser input; deterministic cases for empty/missing/whitespace delimiters, formatting markers, hostile HTML, URLs/colons and all modes; 100% core coverage; actual hosted mode-switch/browser acceptance. Retain Darin Kelkhoff's MIT notice. Part of #1, not a completed port. Substantial AI assistance: Codex (GPT-6).
Implemented all three persisted modes, CRLF/delimiter fidelity, plain escaped metadata, and sanitized Markdown, with Darin attribution. 149 core tests/100% coverage, build and format pass. Commit
3b6ebf8hosted 29/30 UI: table contents appeared but lacked accessible-table semantics.Signed
a141929added caption and row headers. CI 38104015508 now passes table presence, then fails its disappearance after Markdown selection (29/30 UI). Exact assertions remain. CodeQL/scripts/security passed; installed producer is still being observed, not restarted. Next diagnostic records fixture settings/logs/UIA snapshot and checks the persisted Markdown choice before table removal. This issue remains open until actual mode switching passes.Latest pointer acceptance on
443b492remains 31/33: actual heading jumps and nested/theme/reload collapse pass, but mode switching and physical resize still fail. Exact-target/descendant verification proves the pointer was on an enabled Markdown menu item; saved mode stays Metadata. Original mode/table/resize assertions and timeouts are intact; this is not a table-cache false positive.Signed/pushed
d59dba2c96settles mouse-down before release, and start/down/move/up separately for the actual drag. Resize timeout now includes saved settings/rectangle/pointer/UIA tree. Zero-warning build, format/docs/hooks pass; no local GUI input. Prior CI/CodeQL producers ended before push. Observe the new head's hosted checks; do not claim these two cases fixed until they pass. Analyzer mitigation is independently verified (scripts 38104988748 SUCCESS, all 13 files plus 55 Pester tests).Previous
d59dba2CI 38105483808 is terminal: 31/33 loose native/UI pass, with the same Markdown frontmatter selection and physical outline resize failures; installed producer also failed. CodeQL/security/scripts/build/format passed. Exact pointer hit verification succeeded, but processing down/up separately did not change the saved mode/width. No assertion was weakened or run retried.Signed/pushed
9ff820fadds opt-in fixture-only native pressed/released/capture-lost, outline drag and frontmatter click traces, to distinguish event delivery from control-handler behavior. It records no document text or keys and does not change routing, focus or capture. Exact new producer: CI 38106466328. No local desktop input. Acceptance remains open.Signed/pushed
4bf0b81b85with zero-warning build/format/docs/hooks passed. Exact current CI 38106991467 and CodeQL 38106991641 are running; no local physical input.Prior
9ff820fCI 38106466328 finished: 31/34 loose and 31/34 published UI, no skips. Build/format/CodeQL/scripts/security passed. Installed channels were not reached. Captured native events narrow the failures:The follow-up injects actual Windows MOVE input through existing FlaUI APIs instead of SetCursorPos-only movement, and declares source controls before WebView2 without changing their visual columns. Mode/table/exact-target/70-pixel resize assertions stay intact; source acceptance also tests a real divider drag. New entered/exited/moved traces retain evidence if another failure remains. This is an implementation correction awaiting proof, not a passed-acceptance claim.
Full source synchronization/find/vim and PRODUCT.md scope remain active; PR #3 remains draft. No merge/tag/release/Azure retries.
Scoped acceptance is now verified on signed
4bf0b81b85: CI 38106991467 fully SUCCESS. Exact TRX: loose native/UI 34/34, published 34/34, installed stable/dev 33/33 each; no skips. Actual frontmatter mode changes, outline visibility/depth/physical resize, browser heading/nested collapse/theme/reload behavior and literal-source/read-only/reload/physical resize all pass. CodeQL/scripts/security also pass. Artifacts retained in artifacts/native-move-installed-38106991467.The pointer fix used real SendInput MOVE events rather than cursor-only warping; native source declaration ordering follows the verified browser-provider ordering fix. Original outcome assertions remain. PR #3 now closes #8/#9 on reviewed merge; neither is closed early. Full source synchronization/find/vim scope remains in #10/#1. Unsigned fixture success is not production signing evidence.