KofTwentyTwo/Munitor
2
0 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 12 Wiki Activity

Adoption: org-neutral defaults for non-KofTwentyTwo consumers #27

New Issue
Open
opened 2026-10-12 10:33:31 +00:00 by KofTwentyTwo · 1 comment
KofTwentyTwo commented 2026-10-12 10:33:31 +00:00 (Migrated from github.com)
Copy link
Copy source

Context: me-health-portal (dmdbrands, Java/Maven, currently on the Munitor-derived gg-devops/faber@4.0) is the reference second consumer. README now has ## Adopting in another app (#25). Remaining coupling:

  1. generate_config.sh KNOWN_KEYS lacks org, so the documented org: override block prints Unknown key 'org'. Add org (and repack packed_generate_config.sh).
  2. KofTwentyTwo defaults are hard-coded in job parameters and scripts: docker_build_push registry ghcr.io/KofTwentyTwo, node_build_and_test npm scope @koftwentytwo, sonar_scan/node_sonar_scan org KofTwentyTwo, CI email munitor-ci@koftwentytwo.com. Plan: derive every default from .munitor.yml org.* (add org.sonar_org) and pass it through the generated pipeline so job-parameter defaults are never used.
  3. gradle-webapp pipeline type exists (template + server_module) but is not documented in the README pipeline list.
  4. Production model differs from Faber (tag-driven prod vs merge-to-main + atomic tag reservation). Document a migration note when MHP evaluates switching.
Context: me-health-portal (dmdbrands, Java/Maven, currently on the Munitor-derived `gg-devops/faber@4.0`) is the reference second consumer. README now has `## Adopting in another app` (#25). Remaining coupling: 1. `generate_config.sh` `KNOWN_KEYS` lacks `org`, so the documented `org:` override block prints `Unknown key 'org'`. Add `org` (and repack `packed_generate_config.sh`). 2. KofTwentyTwo defaults are hard-coded in job parameters and scripts: `docker_build_push` registry `ghcr.io/KofTwentyTwo`, `node_build_and_test` npm scope `@koftwentytwo`, `sonar_scan`/`node_sonar_scan` org `KofTwentyTwo`, CI email `munitor-ci@koftwentytwo.com`. Plan: derive every default from `.munitor.yml` `org.*` (add `org.sonar_org`) and pass it through the generated pipeline so job-parameter defaults are never used. 3. `gradle-webapp` pipeline type exists (template + `server_module`) but is not documented in the README pipeline list. 4. Production model differs from Faber (tag-driven prod vs merge-to-main + atomic tag reservation). Document a migration note when MHP evaluates switching.
KofTwentyTwo commented 2026-10-12 11:25:05 +00:00 (Migrated from github.com)
Copy link
Copy source

Item 1 is done in 0.3.4 (#29): org is in KNOWN_KEYS, so the documented org: block no longer warns. Related change: GitOps bump commits are now created through the GitHub API and authored by the token identity, so org.ci_email/org.ci_name no longer affect them. Items 2-4 (deriving every default from org.*, documenting gradle-webapp, the Faber migration note) remain open.

🤖 Generated with Claude Code

Item 1 is done in 0.3.4 (#29): `org` is in `KNOWN_KEYS`, so the documented `org:` block no longer warns. Related change: GitOps bump commits are now created through the GitHub API and authored by the token identity, so `org.ci_email`/`org.ci_name` no longer affect them. Items 2-4 (deriving every default from `org.*`, documenting `gradle-webapp`, the Faber migration note) remain open. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/Munitor#27