Files
VisionPOC/Sources/Process/ActivityRecognizer.swift
james.maesandClaude Opus 4.7 958da3bb95 Event bus + greeter + gestures + activity + spatial + history + recording + tests + CI + CLAUDE.md
Four parallel agents shipped Tier 1+2+3 of the punch list, coordinated
through a fixed DetectionEventBus contract created upfront.

## Detection event bus (shared contract)
- Sources/Process/DetectionEvents.swift — `DetectionEvent.Kind` enum
  covering objectAppeared/Refreshed/Disappeared, faceRecognized,
  faceSeenUnknown, textRecognized, gestureDetected, activityDetected,
  spatialRelation.
- Sources/Process/DetectionEventBus.swift — thread-safe pub/sub, Token
  pattern with auto-unsubscribe on deinit, synchronous emit on caller's
  queue. Subscribers hop to their own queue as needed.

## ObjectDetector additions (Agent A)
- Publishes events for every track-add, track-loss, face-match,
  unmatched-face, recognized-text — with per-event throttles (text 2s
  per string, face name 5s, etc.) so the bus doesn't drown in repeats.
- New `DetectorStageTiming` struct + `lastStageTiming` accessor exposes
  the visionBundleMs / featurePrintMs / trackerMs / totalMs breakdown.
  Logged once a second at DEBUG level for visibility.
- Track UUID persistence via Sources/Process/TrackStore.swift
  — label→UUID at ~/Library/Application Support/VisionPOC/tracks.json,
  MRU-pruned to 50 entries, debounced 500ms saves. Same object across
  launches gets the same trackId → consistent per-track color.
- YOLO warmup at init (dispatched on detector queue): one dummy
  inference against a 416×416 mid-gray image so the first user-visible
  detection doesn't pay model-compile latency.

## Event consumers (Agent A)
- Sources/Process/Greeter.swift — AVSpeechSynthesizer-driven "Hello,
  <name>" on faceRecognized events. Honors Theme.greeterMuted and the
  Privacy Mode toggle. Throttle: 30s per name on top of the bus-level
  5s throttle.
- Sources/Process/GestureRecognizer.swift — five gesture heuristics
  (thumbs_up, open_hand, fist, pointing, peace) over hand-pose
  PoseDetections. Throttled 2s per gesture name.
- Sources/Process/ActivityRecognizer.swift — standing/sitting/
  crouching/hand_raised over body-pose PoseDetections. Throttled 5s
  per activity.
- Sources/Process/SpatialReasoner.swift — near/above/inside/holding
  relations between Detection pairs. Throttled 10s per triple.

## Video recording (Agent B)
- Sources/Render/Recorder.swift — @MainActor AVAssetWriter pipeline
  writing H.264 / 12 Mbps / 60fps to ~/Desktop/VisionPOC-...mov.
  Captures the rendered MTKView output via a new frame-tap callback
  on Renderer. Synchronous blit→staging-texture→CVPixelBuffer→
  AVAssetWriterInputPixelBufferAdaptor pattern; ~5-15ms per frame at
  1080p, drops dynamically when active. Format-guarded for bgra8Unorm
  drawables and disabled when not recording (early return).
- Renderer.swift gained `var frameTap` callback; invoked inside
  draw(in:) just before present, when set.

## History window (Agent C)
- Sources/App/HistoryEntry.swift, HistoryStore.swift, HistoryView.swift,
  HistoryWindowController.swift — singleton ring buffer of 500 recent
  events translated into human-readable summaries with category tags
  (object/face-known/face-unknown/ocr/gesture/activity/spatial).
- Open via ⌘H from the Faces menu. Polls the store at 1Hz.
- Window position persists under VPOC.HistoryWindowFrame.

## Privacy mode (Agent C)
- Theme.Performance.faceRecognitionDisabled — new live tunable.
- Camera menu toggle (⇧⌘P) flips both faceRecognitionDisabled and
  greeterMuted. The History viewer also filters out face entries when
  the flag is set.
- Documented limitation: bounding-box labels may still show enrolled
  names if the detector doesn't consult faceRecognitionDisabled (this
  round it doesn't; flag is for History + TTS only).

## Recording menu wiring (Agent C)
- App menu gains "Start Recording" / "Stop Recording" (⇧⌘R). Title
  flips based on the Recorder's isRecording state.
- Start: instantiates the recorder, calls startRecording at the
  current drawable size, hooks renderer.frameTap.
- Stop: clears frameTap first (no more frames queue) then awaits the
  asset writer's finalize. On completion (MainActor hop), shows an
  NSAlert with the saved-path or failure.

## Settings panel additions (Agent C)
- New "Faces" subsection: "Mute greeter (TTS)" toggle bound to
  TunableSettings.greeterMuted (writes through to Theme).
- New "Diagnostics" section: per-stage detector timing readout polled
  at 2Hz. Decoupled from ObjectDetector via a closure-based timing
  provider so the App layer doesn't depend on the Process module's
  DetectorStageTiming type directly.

## Hygiene (Agent D)
- Tests/IoUTests.swift, AspectFitTests.swift, LogStreamTests.swift,
  DetectionEventBusTests.swift, FaceRegistryDistanceTests.swift
  — 24 tests covering pure-logic algorithms. Private methods are
  mirrored verbatim into the test files with a "keep in sync" comment.
- project.yml gains a `VisionPOCTests` target of type
  `bundle.unit-test`, depending on the VisionPOC application target.
- .github/workflows/build.yml — macos-15 runner, brew install xcodegen,
  generate, build, test. LFS skipped to save bandwidth (the build
  tolerates a missing model since ObjectDetector falls back to Vision
  built-ins).
- CLAUDE.md — onboarding doc covering project layout, theme tunables,
  pipelines, event vocabulary, observability, build idiosyncrasies,
  and "how to add a new detector / overlay" recipes.

## Integration fix
- Recorder.swift's `stopRecording` completion path crossed actor
  isolation boundaries — captured a `(URL?) -> Void` closure and the
  AVAssetWriter instance into a @Sendable closure. Fixed by extracting
  `writer.status` / `writer.error?.localizedDescription` on the
  writer's queue before hopping, and wrapping the completion in a
  `nonisolated(unsafe)` shuttle (it's called from MainActor only, so
  the unsafe annotation is honest).

## Build status
- `xcodebuild build` — clean
- `xcodebuild test` — 24 / 24 passing

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-16 17:20:54 -05:00

105 lines
4.2 KiB
Swift

import Foundation
import CoreGraphics
/// Inspects body `PoseDetection`s and emits coarse activity events on the
/// shared DetectionEventBus. Heuristics over normalized [0..1] image-space
/// joint positions (origin bottom-left, so larger y = higher in the scene).
///
/// Joint extraction: PoseDetection only carries an unordered `points` array
/// without name labels, so we approximate landmark positions from positional
/// statistics:
/// - "root" / hip ≈ vertical median of the joint cluster
/// - "neck" / upper-body ≈ near-top y of the joint cluster
/// - "nose" ≈ topmost y
/// - "wrists" ≈ the points farthest from the body's central vertical axis
/// among the upper half
///
/// Throttle: one emit per activity per 5 seconds.
final class ActivityRecognizer: @unchecked Sendable {
private let bus: DetectionEventBus
private var lock = os_unfair_lock_s()
private var lastEmittedAt: [String: Date] = [:]
private let throttleInterval: TimeInterval = 5.0
init(bus: DetectionEventBus = .shared) {
self.bus = bus
}
/// Called by ObjectDetector at the end of each detect-and-bootstrap pass
/// with the freshly-computed body-pose snapshots.
func process(bodyPoses: [PoseDetection]) {
for pose in bodyPoses where pose.kind == .body {
evaluate(pose: pose)
}
}
private func evaluate(pose: PoseDetection) {
let points = pose.points
guard points.count >= 5 else { return }
let ys = points.map { Float($0.y) }
let xs = points.map { Float($0.x) }
let minY = ys.min() ?? 0
let maxY = ys.max() ?? 0
// Pseudo "root" ≈ vertical center of the body cluster; "neck" ≈ near
// the top; "nose" ≈ the topmost joint.
let rootY = (minY + maxY) * 0.5
let neckY = (minY + maxY * 3) / 4.0
let noseY = maxY
// ---- standing ----
if rootY < 0.3 && (neckY - rootY) > 0.3 {
let strength = min(1.0, (neckY - rootY - 0.3) / 0.3 + 0.3)
emit("standing", confidence: max(0, min(1, strength)))
}
// ---- sitting ----
if rootY >= 0.3 && rootY <= 0.5 {
// Confidence peaks in the middle of the band, tapers at edges.
let center: Float = 0.4
let strength = 1.0 - abs(rootY - center) / 0.1
emit("sitting", confidence: max(0, min(1, strength)))
}
// ---- crouching ----
if rootY > 0.5 && neckY < 0.7 {
let strength = min(1.0, (rootY - 0.5) / 0.3)
emit("crouching", confidence: max(0, min(1, strength)))
}
// ---- hand_raised: any joint above the nose ----
// Wrists aren't tagged in our point set, but if *any* keypoint is
// above the inferred nose y (which is already the topmost), the
// rule can't fire — so instead we look for a wrist-like point: a
// joint among the top-quartile y values that's *also* an extremum
// in x. The wrist is usually farthest from the body's vertical axis.
let bodyCenterX = (xs.reduce(0, +)) / Float(xs.count)
let topQuartileThreshold: Float = noseY - 0.10
let upperPoints = zip(xs, ys).filter { $0.1 >= topQuartileThreshold }
let wristCandidate = upperPoints.max(by: { abs($0.0 - bodyCenterX) < abs($1.0 - bodyCenterX) })
if let (wx, wy) = wristCandidate {
// A "raised hand" means a joint that's near or above nose y and
// displaced laterally from the body's centerline.
let lateralOffset = abs(wx - bodyCenterX)
if wy >= noseY - 0.02 && lateralOffset > 0.10 {
let strength = min(1.0, (lateralOffset - 0.10) / 0.20 + 0.3)
emit("hand_raised", confidence: max(0, min(1, strength)))
}
}
}
private func emit(_ name: String, confidence: Float) {
let now = Date()
os_unfair_lock_lock(&lock)
if let prev = lastEmittedAt[name], now.timeIntervalSince(prev) < throttleInterval {
os_unfair_lock_unlock(&lock)
return
}
lastEmittedAt[name] = now
os_unfair_lock_unlock(&lock)
bus.emit(.activityDetected(activity: name, confidence: confidence))
}
}