Tax planning has no calculator: TaxPreparation returns UNDETERMINED for every packet #17

New Issue

2026-10-01T22:50:47Z

KofTwentyTwo commented

2026-10-01 22:50:47 +00:00

(Migrated from github.com)

Summary

src/main/java/com/kof22/carlai/domain/TaxPreparation.java:309 returns the literal "UNDETERMINED", "No implemented, qualified tax-rule package or tax calculator." for every packet. TaxPlanningRecords stores references and alternatives only (:60-156). The code is honest. The navigation ("Tax" section app), docs/TAX-PLANNING-SOURCES.md and the requirement rows marked PASS for tax planning can read as if tax computation exists.

Suggested resolution

Label the Tax section and its process descriptions as evidence collection with no computed liability, and mark the tax-computation requirements as NOT IMPLEMENTED rather than PASS where the test only checks packet assembly.

Priority rationale

P2: expectation mismatch for a financial product.

Filed from the 2026-10-01 real-versus-fake audit of Carl (branch feature/cicd-liquibase-gitops, HEAD 5414d7a, main 1b334d1). Four read-only reviews covered domain and services, QQQ metadata and data model, tests/CI/evidence, and docs/integrations. A local offline build of a Carl copy against the installed foundation 0.5.0-SNAPSHOT is in progress; its result will be added as a comment. Existing issues #3, #4 and #5 (real Monarch accounts, Authentik with real data, CI/CD with Liquibase and ArgoCD) are referenced rather than duplicated.

## Summary `src/main/java/com/kof22/carlai/domain/TaxPreparation.java:309` returns the literal `"UNDETERMINED", "No implemented, qualified tax-rule package or tax calculator."` for every packet. `TaxPlanningRecords` stores references and alternatives only (`:60-156`). The code is honest. The navigation ("Tax" section app), `docs/TAX-PLANNING-SOURCES.md` and the requirement rows marked PASS for tax planning can read as if tax computation exists. ## Suggested resolution Label the Tax section and its process descriptions as evidence collection with no computed liability, and mark the tax-computation requirements as NOT IMPLEMENTED rather than PASS where the test only checks packet assembly. ## Priority rationale P2: expectation mismatch for a financial product. --- Filed from the 2026-10-01 real-versus-fake audit of Carl (branch `feature/cicd-liquibase-gitops`, HEAD `5414d7a`, main `1b334d1`). Four read-only reviews covered domain and services, QQQ metadata and data model, tests/CI/evidence, and docs/integrations. A local offline build of a Carl copy against the installed foundation 0.5.0-SNAPSHOT is in progress; its result will be added as a comment. Existing issues #3, #4 and #5 (real Monarch accounts, Authentik with real data, CI/CD with Liquibase and ArgoCD) are referenced rather than duplicated.

KofTwentyTwo commented

2026-10-04 13:22:06 +00:00

(Migrated from github.com)

Deferred by owner decision (2026-10-04). Leaving this open; it is not scheduled for current work.

This repo is archived. You cannot comment on issues.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KofTwentyTwo/carl#17