KofTwentyTwo/carl
Archived
2
0 Fork 0
Code Issues 34 Actions Packages Projects Releases Wiki Activity

Two environment names for the Anthropic key between runtime config and the e2e harness #22

New Issue
Open
opened 2026-10-01 22:50:54 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-10-01 22:50:54 +00:00 (Migrated from github.com)
Copy link
Copy source

Summary

config/agent.properties:21 documents KOF22_AGENT_ANTHROPIC_API_KEY; the e2e harness reads ANTHROPIC_API_KEY and maps it (scripts/e2e/CarlPackagedVisualFixture.java:207-211, scripts/e2e/README.md:16). Operators following one document will set the wrong variable for the other.

Suggested resolution

Standardize on the foundation's KOF22_AGENT_* name in the harness and docs.

Priority rationale

P3: footgun.

Filed from the 2026-10-01 real-versus-fake audit of Carl (branch feature/cicd-liquibase-gitops, HEAD 5414d7a, main 1b334d1). Four read-only reviews covered domain and services, QQQ metadata and data model, tests/CI/evidence, and docs/integrations. A local offline build of a Carl copy against the installed foundation 0.5.0-SNAPSHOT is in progress; its result will be added as a comment. Existing issues #3, #4 and #5 (real Monarch accounts, Authentik with real data, CI/CD with Liquibase and ArgoCD) are referenced rather than duplicated.

## Summary `config/agent.properties:21` documents `KOF22_AGENT_ANTHROPIC_API_KEY`; the e2e harness reads `ANTHROPIC_API_KEY` and maps it (`scripts/e2e/CarlPackagedVisualFixture.java:207-211`, `scripts/e2e/README.md:16`). Operators following one document will set the wrong variable for the other. ## Suggested resolution Standardize on the foundation's `KOF22_AGENT_*` name in the harness and docs. ## Priority rationale P3: footgun. --- Filed from the 2026-10-01 real-versus-fake audit of Carl (branch `feature/cicd-liquibase-gitops`, HEAD `5414d7a`, main `1b334d1`). Four read-only reviews covered domain and services, QQQ metadata and data model, tests/CI/evidence, and docs/integrations. A local offline build of a Carl copy against the installed foundation 0.5.0-SNAPSHOT is in progress; its result will be added as a comment. Existing issues #3, #4 and #5 (real Monarch accounts, Authentik with real data, CI/CD with Liquibase and ArgoCD) are referenced rather than duplicated.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Labels
Clear labels
accessibility
Barrier affecting people with disabilities
 audit-2026-10-01
Found by the October 1 2026 full codebase audit
 bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 priority: P0
Critical: blocks release or is a correctness/security defect
 priority: P1
High: must fix before next release
 priority: P2
Medium: should fix soon
 priority: P3
Low: cleanup or nice to have
 question
Further information is requested
 tech-debt
Bloat, dead code, or housekeeping
 wontfix
This will not be worked on
No labels audit-2026-10-01 priority: P3 tech-debt
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/carl#22