UI test fixture: only the fixture token is affected, and never in an installed build #145

New Issue

2026-11-10T19:38:58Z

james.maes commented

2026-11-10 19:38:58 +00:00

Problem

The app has an offline fixture for its UI tests: with GCLO_UITEST_FIXTURE=1 in the environment, a workspace whose token is the fixture's fixed token is answered from a built-in organization instead of GitHub. Two things about it are looser than intended:

with the variable set, IsValidRepository answers "no" for every token, not only the fixture's, so in a real session every existing repository is treated as missing;
the variable is honoured in installed release builds, and nothing records that it was.

Scope

The fixture's git client asks the real client whether a folder is a repository.
The variable is ignored when the app runs as a Velopack-installed build.
One activity-log line when the fixture is enabled.
Threat model wording corrected.

Acceptance

The UI suite passes against the unpackaged build. Zero warnings; format clean.

## Problem The app has an offline fixture for its UI tests: with `GCLO_UITEST_FIXTURE=1` in the environment, a workspace whose token is the fixture's fixed token is answered from a built-in organization instead of GitHub. Two things about it are looser than intended: - with the variable set, `IsValidRepository` answers "no" for every token, not only the fixture's, so in a real session every existing repository is treated as missing; - the variable is honoured in installed release builds, and nothing records that it was. ## Scope - The fixture's git client asks the real client whether a folder is a repository. - The variable is ignored when the app runs as a Velopack-installed build. - One activity-log line when the fixture is enabled. - Threat model wording corrected. ## Acceptance The UI suite passes against the unpackaged build. Zero warnings; format clean.

james.maes added the quality label 2026-11-10 19:38:58 +00:00

james.maes referenced this issue from a commit

2026-11-10 19:41:11 +00:00

fix(app): scope the UI test fixture to its token, never in an installed build

james.maes referenced a pull request that will close this issue

2026-11-10 19:41:11 +00:00

fix(app): scope the UI test fixture to its token, never in an installed build #146

james.maes referenced this issue from a commit

2026-11-10 21:46:46 +00:00

fix(app): scope the UI test fixture to its token, never in an installed build

james.maes referenced this issue from a commit

2026-11-10 21:46:48 +00:00