fix(app): a saved token is read when it is used, not once when a workspace opens #157

Closed
opened 2026-11-10 22:10:54 +00:00 by james.maes · 0 comments
Owner

Found in the 1.1.1 review.

A saved token is read once, when a workspace is opened. After the default token is replaced or removed in Settings, account workspaces that are already open keep using the old one until the app is restarted. After a default token is saved for the first time, Sync all still skips the accounts that use it. Quick Sync, which Settings pre-fills, keeps the old value too. The Settings caption and docs/plans/default-token-ux.md say a replacement takes effect for every account that uses the default token.

Expected: a workspace takes its account's token from its source at the moment it is used (loading repositories, syncing, Sync all), and the open workspaces are told when Settings changed the default token. Quick Sync follows only while its box still holds what Settings put there; a token somebody typed stays.

Editing an account that uses the default token while none is saved is a dead end. The wizard hides the choice between the default token and a token of the account's own when no default token is saved, so step 2 says "use a different token for this account" with no way to do so.

The "no token" message names the wrong credential entry for a data folder other than the default one (the entry names are scoped to the data folder there).

Found in the 1.1.1 review. **A saved token is read once, when a workspace is opened.** After the default token is replaced or removed in Settings, account workspaces that are already open keep using the old one until the app is restarted. After a default token is saved for the first time, Sync all still skips the accounts that use it. Quick Sync, which Settings pre-fills, keeps the old value too. The Settings caption and `docs/plans/default-token-ux.md` say a replacement takes effect for every account that uses the default token. Expected: a workspace takes its account's token from its source at the moment it is used (loading repositories, syncing, Sync all), and the open workspaces are told when Settings changed the default token. Quick Sync follows only while its box still holds what Settings put there; a token somebody typed stays. **Editing an account that uses the default token while none is saved is a dead end.** The wizard hides the choice between the default token and a token of the account's own when no default token is saved, so step 2 says "use a different token for this account" with no way to do so. **The "no token" message names the wrong credential entry** for a data folder other than the default one (the entry names are scoped to the data folder there).
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/gclo#157