test: the suites write nothing outside their own folders and send nothing anywhere #161

New Issue

2026-11-10T22:41:30Z

james.maes commented

2026-11-10 22:41:30 +00:00

Found in the 1.1.1 review. The test suites should be safe to run on a developer's machine and should not fail or leave things behind for reasons of their own.

Settings tests set the process-wide GCLO_DATA_DIR variable; a test that saves settings while another class has reset the variable can write to the developer's real settings.json. The settings store should take a folder, so its tests name one.
The tests of the Credential Manager vault write to the real Credential Manager under the names the installed app uses.
A UI smoke test types a made-up token of plausible length, which the app sends to the real API to be refused. The UI suite is meant to run without network access.
The synchronous progress double used by the view-model tests lets several workers enter the view model's progress handler at once, which the UI thread never does.
Tests leave empty folders under the temp folder on every run.
One test has no assertion; two await without a time limit.

Found in the 1.1.1 review. The test suites should be safe to run on a developer's machine and should not fail or leave things behind for reasons of their own. - Settings tests set the process-wide `GCLO_DATA_DIR` variable; a test that saves settings while another class has reset the variable can write to the developer's real `settings.json`. The settings store should take a folder, so its tests name one. - The tests of the Credential Manager vault write to the real Credential Manager under the names the installed app uses. - A UI smoke test types a made-up token of plausible length, which the app sends to the real API to be refused. The UI suite is meant to run without network access. - The synchronous progress double used by the view-model tests lets several workers enter the view model's progress handler at once, which the UI thread never does. - Tests leave empty folders under the temp folder on every run. - One test has no assertion; two await without a time limit.

james.maes referenced this issue from a commit

2026-11-10 22:43:05 +00:00

test: the suites write nothing outside their own folders and send nothing anywhere

james.maes referenced a pull request that will close this issue

2026-11-10 22:43:06 +00:00

test: the suites write nothing outside their own folders and send nothing anywhere #162

james.maes referenced this issue from a commit

2026-11-10 23:02:41 +00:00

test: the suites write nothing outside their own folders and send nothing anywhere

james.maes referenced this issue from a commit

2026-11-10 23:02:41 +00:00

test: the newer workspace tests use the tracked temp folders too