KofTwentyTwo/gclo
2
0 Fork 0
Code Issues 28 Pull Requests 1 Actions Packages Projects Releases 22 Wiki Activity

Sync all follows accounts that are edited or deleted while it runs #180

New Issue
Open
opened 2026-11-11 05:31:42 +00:00 by james.maes · 0 comments
james.maes commented 2026-11-11 05:31:42 +00:00
Owner
Copy link
Copy source

From the full review of 2026-11-10. Part of it shipped in 1.1.1 (#167, #168: the status row, cancel, the count of failed accounts). The rest was moved to 1.2.0 by the owner's decision.

What remains

  • A Sync all pass takes its list of workspaces when it starts. An account that is edited or deleted while the pass runs is still synced with the profile it had at the start.
  • Commands of a workspace that was disposed (its account deleted) still run when the pass reaches it.
  • The UI suite has no test for the Sync all status row (running, canceling, finished, failed).

Expected

  • The pass queues account ids and resolves the live workspace when each turn starts; an account that is gone is skipped and counted as skipped.
  • A disposed workspace refuses its commands.
  • UI tests for the status row's states.

Notes

Re-verify against current main before working on it. Every fix needs a regression test that fails without it.

From the full review of 2026-11-10. Part of it shipped in 1.1.1 (#167, #168: the status row, cancel, the count of failed accounts). The rest was moved to 1.2.0 by the owner's decision. ## What remains - A Sync all pass takes its list of workspaces when it starts. An account that is edited or deleted while the pass runs is still synced with the profile it had at the start. - Commands of a workspace that was disposed (its account deleted) still run when the pass reaches it. - The UI suite has no test for the Sync all status row (running, canceling, finished, failed). ## Expected - The pass queues account ids and resolves the live workspace when each turn starts; an account that is gone is skipped and counted as skipped. - A disposed workspace refuses its commands. - UI tests for the status row's states. ## Notes Re-verify against current `main` before working on it. Every fix needs a regression test that fails without it.
james.maes added the bugdeferred labels 2026-11-11 05:31:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
.NET
Pull requests that update .NET code
 bug
Something isn't working
 deferred
Agreed follow-up, not scheduled
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 needs-owner
Blocked on an action only the owner can take
 priority
Owner-flagged: work this first
 quality
Standards, simplicity, enforcement
 question
Further information is requested
 refactor
Restructuring without behavior change
 release
Release pipeline / distribution
 wontfix
This will not be worked on
No labels bug deferred
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/gclo#180