An account's page ignores a typed token, and Sync all reports accounts it could not sync as a success #182

New Issue

2026-11-11T05:42:54Z

james.maes commented

2026-11-11 05:42:54 +00:00

Found by the design review of the 1.1.1 release candidate (main at 6696e37); both reproduced with the view models and fakes, and confirmed by reading the code.

1. A saved account's page takes a token that is then ignored

When a saved account's repositories cannot be loaded (its token expired, or it has none), its page shows the connect card with an editable token box whose tooltip says "Type here to use a different one for this session".

A token typed there refreshes the organization list, but Load reads the account's saved token again and uses that: the same failure returns.
With no saved token, Load is disabled and nothing on the card says why.
The way to fix the account (Edit account…) is only in the pane's context menu until a load has succeeded.

Since #158 an account's token is read from where it is saved at the moment it is used. The box was left behind.

Expected: on an account's page the token box takes no input and says the token is saved with the account; the card offers Edit account…, and says why Load cannot run when the account has no token. Quick Sync keeps its editable box.

2. Sync all reports accounts it could not sync as a success

An account whose token is missing or rejected, or whose repositories cannot be loaded, is counted as "skipped". With nothing else wrong the status row shows a green check and "Sync all finished: 0 accounts synced, 1 skipped."
After a cancel the row says "1 account synced, 0 skipped." while the accounts that never started are not mentioned.

Expected: an account that could not be synced is marked as needing attention and the pass ends as "finished with failures"; a canceled pass says how many accounts were not started. An account that was busy, or had nothing to sync, stays "skipped".

Also

"1 repositories loaded." and "Syncing 1 repositories...".

Found by the design review of the 1.1.1 release candidate (main at 6696e37); both reproduced with the view models and fakes, and confirmed by reading the code. ## 1. A saved account's page takes a token that is then ignored When a saved account's repositories cannot be loaded (its token expired, or it has none), its page shows the connect card with an editable token box whose tooltip says "Type here to use a different one for this session". - A token typed there refreshes the organization list, but Load reads the account's saved token again and uses that: the same failure returns. - With no saved token, Load is disabled and nothing on the card says why. - The way to fix the account (Edit account…) is only in the pane's context menu until a load has succeeded. Since #158 an account's token is read from where it is saved at the moment it is used. The box was left behind. **Expected:** on an account's page the token box takes no input and says the token is saved with the account; the card offers Edit account…, and says why Load cannot run when the account has no token. Quick Sync keeps its editable box. ## 2. Sync all reports accounts it could not sync as a success - An account whose token is missing or rejected, or whose repositories cannot be loaded, is counted as "skipped". With nothing else wrong the status row shows a green check and "Sync all finished: 0 accounts synced, 1 skipped." - After a cancel the row says "1 account synced, 0 skipped." while the accounts that never started are not mentioned. **Expected:** an account that could not be synced is marked as needing attention and the pass ends as "finished with failures"; a canceled pass says how many accounts were not started. An account that was busy, or had nothing to sync, stays "skipped". ## Also - "1 repositories loaded." and "Syncing 1 repositories...".

james.maes added the bug label 2026-11-11 05:42:54 +00:00

james.maes referenced this issue from a commit

2026-11-11 05:57:13 +00:00

fix(app): an account's page takes no token it would ignore, and Sync all does not call an unsynced account synced

james.maes referenced a pull request that will close this issue

2026-11-11 05:57:13 +00:00

fix(app): an account's page takes no token it would ignore, and Sync all does not call an unsynced account synced #185

james.maes referenced this issue from a commit

2026-11-11 06:19:52 +00:00

fix(app): second review of #185: every account is counted once in the Sync all result, and Retry failed does not touch the selection

james.maes referenced this issue from a commit

2026-11-11 06:20:31 +00:00