KofTwentyTwo/gclo
2
0 Fork 0
Code Issues 28 Pull Requests 1 Actions Packages Projects Releases 22 Wiki Activity

Extract gclo.ViewModels library — no business logic in the UI project #3

New Issue
Closed
opened 2026-07-03 13:58:56 +00:00 by KofTwentyTwo · 1 comment
KofTwentyTwo commented 2026-07-03 13:58:56 +00:00 (Migrated from github.com)
Copy link
Copy source

Owner rule: all business logic lives in shared libraries; the WinUI project keeps only XAML, dialogs, pickers, brushes, and update plumbing.

  • New gclo.ViewModels classlib (net10.0; refs gclo.Engine + CommunityToolkit.Mvvm — UI-framework-free).
  • Move MainViewModel, RepoItemViewModel, AppSettings persistence (the one WinUI theme-mapping method stays in the app).
  • Add a progress-factory seam so view models are unit-testable (Progress capture makes tests racy otherwise).
  • Add view-model unit tests: command gating, progress aggregation, debounced org lookup + cancellation, error surfacing.
  • Update slnx, README project layout.

Domain logic already lives in gclo.Engine (published to NuGet by the release pipeline); this closes the remaining gap.

Owner rule: all business logic lives in shared libraries; the WinUI project keeps only XAML, dialogs, pickers, brushes, and update plumbing. - New `gclo.ViewModels` classlib (net10.0; refs gclo.Engine + CommunityToolkit.Mvvm — UI-framework-free). - Move `MainViewModel`, `RepoItemViewModel`, `AppSettings` persistence (the one WinUI theme-mapping method stays in the app). - Add a progress-factory seam so view models are unit-testable (Progress<T> capture makes tests racy otherwise). - Add view-model unit tests: command gating, progress aggregation, debounced org lookup + cancellation, error surfacing. - Update slnx, README project layout. Domain logic already lives in `gclo.Engine` (published to NuGet by the release pipeline); this closes the remaining gap.
KofTwentyTwo commented 2026-07-03 15:44:50 +00:00 (Migrated from github.com)
Copy link
Copy source

Shipped: gclo.ViewModels library extracted (view models + settings persistence, UI-framework-free, injectable seams) with view-model test coverage. UI project contains only XAML/dialogs/pickers/update plumbing.

Shipped: gclo.ViewModels library extracted (view models + settings persistence, UI-framework-free, injectable seams) with view-model test coverage. UI project contains only XAML/dialogs/pickers/update plumbing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
.NET
Pull requests that update .NET code
 bug
Something isn't working
 deferred
Agreed follow-up, not scheduled
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 needs-owner
Blocked on an action only the owner can take
 priority
Owner-flagged: work this first
 quality
Standards, simplicity, enforcement
 question
Further information is requested
 refactor
Restructuring without behavior change
 release
Release pipeline / distribution
 wontfix
This will not be worked on
No labels refactor
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/gclo#3