release: packaging PR commit has no DCO sign-off, so pr / dco fails #81

New Issue

2026-10-10T14:59:45Z

KofTwentyTwo commented

2026-10-10 14:59:45 +00:00

(Migrated from github.com)

The packages job of release.yml opens the build(packaging): … pull request through peter-evans/create-pull-request, but the generated commit carries no Signed-off-by: trailer. The standards' pr / dco gate requires one whose email matches the commit author, so the first real packaging PR (#80, for v1.0.1) failed that required check and cannot merge on its own.

Fix: set signoff: true and give the action an explicit author and committer that are the same identity (the actor who pushed the tag, <id>+<login>@users.noreply.github.com), so the sign-off the action adds matches the author the DCO check compares against.

#80 itself is fixed by amending its commit with a sign-off; this issue is the permanent fix. Part of #62.

The `packages` job of `release.yml` opens the `build(packaging): …` pull request through `peter-evans/create-pull-request`, but the generated commit carries no `Signed-off-by:` trailer. The standards' `pr / dco` gate requires one whose email matches the commit author, so the first real packaging PR (#80, for v1.0.1) failed that required check and cannot merge on its own. Fix: set `signoff: true` and give the action an explicit `author` and `committer` that are the same identity (the actor who pushed the tag, `<id>+<login>@users.noreply.github.com`), so the sign-off the action adds matches the author the DCO check compares against. #80 itself is fixed by amending its commit with a sign-off; this issue is the permanent fix. Part of #62.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KofTwentyTwo/gclo#81