From 48610f54ccfd78bf4e3b651de96e345198f49f88 Mon Sep 17 00:00:00 2001
From: James Maes <james@kof22.com>
Date: Tue, 10 Nov 2026 12:14:58 -0600
Subject: [PATCH] build: pin the single-file analyzer package so lock files
 survive SDK patches

The SDK adds Microsoft.NET.ILLink.Tasks implicitly, at its own runtime
version, for projects with EnableSingleFileAnalyzer. global.json rolls
forward to the newest 10.0 SDK, so each SDK patch resolved a different
version: a locked restore failed with NU1004 and an unlocked one rewrote
three lock files.

Directory.Build.targets now fixes the version through the SDK's
KnownILLinkPack item, at the one bundled with the SDK named in
global.json. The committed lock files are unchanged and restore in locked
mode with SDK 10.0.403, for a build and for the single-file publish.

Also:
- nuget-updates: commit Directory.Packages.props with the weekly bump;
  without it the pull request carried lock files that no longer matched.
- VersionPrefix: 1.1.1, the next release after v1.1.0.

Closes #137

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
---
 .github/workflows/nuget-updates.yml |  3 +++
 Directory.Build.props               |  4 ++--
 Directory.Build.targets             | 25 +++++++++++++++++++++++++
 3 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 Directory.Build.targets

diff --git a/.github/workflows/nuget-updates.yml b/.github/workflows/nuget-updates.yml
index 25a8821..3571e97 100644
--- a/.github/workflows/nuget-updates.yml
+++ b/.github/workflows/nuget-updates.yml
@@ -152,7 +152,10 @@ jobs:
           labels: |
             dependencies
             .NET
+          # Versions live in Directory.Packages.props (central package management);
+          # without it the pull request carries lock files that no longer match.
           add-paths: |
+            Directory.Packages.props
             **/*.csproj
             **/packages.lock.json
 
diff --git a/Directory.Build.props b/Directory.Build.props
index 2a58e4c..dfb2023 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -53,9 +53,9 @@
        built-in SourceLink appends the git commit as "+<sha>" build metadata on
        AssemblyInformationalVersion, which the About dialog and the CLI's
        version output surface as the short hash. Prefix tracks the next expected
-       release after the last stable tag (v1.0.0). -->
+       release after the last stable tag (v1.1.0). -->
   <PropertyGroup>
-    <VersionPrefix>1.0.1</VersionPrefix>
+    <VersionPrefix>1.1.1</VersionPrefix>
     <VersionSuffix>dev</VersionSuffix>
   </PropertyGroup>
 
diff --git a/Directory.Build.targets b/Directory.Build.targets
new file mode 100644
index 0000000..12553ae
--- /dev/null
+++ b/Directory.Build.targets
@@ -0,0 +1,25 @@
+<Project>
+
+  <!-- Keeps packages.lock.json independent of the installed SDK patch (#137).
+
+       The single-file analyzer (EnableSingleFileAnalyzer in gclo.Engine, gclo.ViewModels
+       and gclo.Cli) makes the SDK add an implicit PackageReference to
+       Microsoft.NET.ILLink.Tasks at the version of its own bundled runtime. global.json
+       rolls forward to the newest 10.0 SDK (the KofTwentyTwo standard), so every SDK
+       patch resolved a different version: a locked restore failed with NU1004, and an
+       unlocked one rewrote three lock files.
+
+       The implicit version comes from the SDK's KnownILLinkPack item; fixing it here
+       pins the analyzer package like any other dependency. Keep it at the version
+       bundled with the SDK named in global.json (the oldest SDK allowed to build this
+       repository), never newer: analyzers built for an older compiler load in a newer
+       SDK, not the reverse. After changing it, refresh the lock files (the restore
+       command with force-evaluate, in CONTRIBUTING.md).
+
+       This lives in Directory.Build.targets, not Directory.Build.props: the item is
+       defined by the SDK's props, which are imported after Directory.Build.props. -->
+  <ItemGroup>
+    <KnownILLinkPack Update="Microsoft.NET.ILLink.Tasks" ILLinkPackVersion="10.0.12" />
+  </ItemGroup>
+
+</Project>
-- 
2.54.0