From 9dd889e26fcf5f5d1369ffe10ce9934240189a59 Mon Sep 17 00:00:00 2001
From: James Maes <james@kof22.com>
Date: Sat, 10 Oct 2026 08:00:34 -0500
Subject: [PATCH] fix(build): enable ReadyToRun and trimming only when
 publishing

gclo.csproj turned PublishReadyToRun and PublishTrimmed on for every non-Debug
configuration, so a plain `dotnet build -c Release` needed the crossgen pack,
which only a restore made with that property downloads. The shared release
workflow restores once without a configuration and then builds Release, and on
a clean runner that failed with NETSDK1094 (rehearsal v1.0.1-beta.2); locally
it passed only because the cache already held the pack.

Both properties now apply only under `_IsPublishing` (set by `dotnet publish`),
so the publish step's own restore fetches what it needs and a Release build
needs nothing extra. Verified against an empty NuGet cache with the workflow's
exact restore, build, test and publish commands.

Closes #78

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
---
 gclo/gclo.csproj | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/gclo/gclo.csproj b/gclo/gclo.csproj
index 926ad71..7aadd78 100644
--- a/gclo/gclo.csproj
+++ b/gclo/gclo.csproj
@@ -66,11 +66,14 @@
     <HasPackageAndPublishMenu>true</HasPackageAndPublishMenu>
   </PropertyGroup>
 
-  <!-- Publish Properties -->
-  <PropertyGroup>
-    <PublishReadyToRun Condition="'$(Configuration)' == 'Debug'">False</PublishReadyToRun>
-    <PublishReadyToRun Condition="'$(Configuration)' != 'Debug'">True</PublishReadyToRun>
-    <PublishTrimmed Condition="'$(Configuration)' == 'Debug'">False</PublishTrimmed>
-    <PublishTrimmed Condition="'$(Configuration)' != 'Debug'">True</PublishTrimmed>
+  <!--
+    Publish-only properties. A plain Release build must not depend on the ReadyToRun
+    (crossgen) and trimming packs: only a publish-time restore downloads them, and the
+    release workflow restores once without a configuration, then builds Release
+    (NETSDK1094 otherwise). `_IsPublishing` is set by `dotnet publish`.
+  -->
+  <PropertyGroup Condition="'$(_IsPublishing)' == 'true' And '$(Configuration)' != 'Debug'">
+    <PublishReadyToRun>True</PublishReadyToRun>
+    <PublishTrimmed>True</PublishTrimmed>
   </PropertyGroup>
 </Project>
\ No newline at end of file
-- 
2.54.0