KofTwentyTwo/license-tool
2
0 Fork 0
Code Issues 2 Pull Requests 9 Actions Packages Projects Releases 6 Wiki Activity

enumerate: include globs ignore ** (mismatch with exclude semantics) #32

New Issue
Open
opened 2026-06-08 16:38:26 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-06-08 16:38:26 +00:00 (Migrated from github.com)
Copy link
Copy source

Found during full-codebase review (see docs/review/02-audit-policy-resolve.md). Blocker for #29 (the init wizard teaches glob authoring and must validate against the real matcher).

[HIGH] internal/enumerate/enumerate.go (~268-282): includes use filepath.Match, which has no ** support, while excludes use go-gitignore (which does). So include: ["src/**"] matches src/x.go but not src/sub/x.go, and **/generated/** matches nothing — yet the config layer documents and round-trips these exact patterns. TestMatchesIncludes asserts the broken single-segment behavior, locking in the bug.

Fix: make includes use the same gitignore-style matcher as excludes; remove the test that enshrines the broken behavior.

Found during full-codebase review (see docs/review/02-audit-policy-resolve.md). **Blocker for #29** (the init wizard teaches glob authoring and must validate against the real matcher). **[HIGH]** `internal/enumerate/enumerate.go` (~268-282): includes use `filepath.Match`, which has no `**` support, while excludes use go-gitignore (which does). So `include: ["src/**"]` matches `src/x.go` but not `src/sub/x.go`, and `**/generated/**` matches nothing — yet the config layer documents and round-trips these exact patterns. `TestMatchesIncludes` asserts the broken single-segment behavior, locking in the bug. Fix: make includes use the same gitignore-style matcher as excludes; remove the test that enshrines the broken behavior.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 go
Pull requests that update go code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/license-tool#32