KofTwentyTwo/license-tool
2
0 Fork 0
Code Issues 2 Pull Requests 9 Actions Packages Projects Releases 6 Wiki Activity

applier: AtomicWrite clobbers a symlinked LICENSE #33

New Issue
Closed
opened 2026-06-08 16:38:27 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-06-08 16:38:27 +00:00 (Migrated from github.com)
Copy link
Copy source

Found during full-codebase review (see docs/review/01-write-path-safety.md).

[MED] internal/applier/applier.go (~283): source files are safe (enumerate skips symlinks), but managed LICENSE/LICENSES/*.txt are written with no symlink check, so os.Rename converts a symlink into a regular file.

Fix: detect a symlinked target and refuse (or resolve) rather than replacing it.

Found during full-codebase review (see docs/review/01-write-path-safety.md). **[MED]** `internal/applier/applier.go` (~283): source files are safe (enumerate skips symlinks), but managed `LICENSE`/`LICENSES/*.txt` are written with no symlink check, so `os.Rename` converts a symlink into a regular file. Fix: detect a symlinked target and refuse (or resolve) rather than replacing it.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 go
Pull requests that update go code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/license-tool#33