KofTwentyTwo/nuncio
2
0 Fork 0
Code Issues 73 Pull Requests 12 Actions Packages Projects Releases Wiki Activity

1.B.4 Transient error is not corruption #155

New Issue
Closed
opened 2026-07-27 00:26:39 +00:00 by KofTwentyTwo · 2 comments
KofTwentyTwo commented 2026-07-27 00:26:39 +00:00 (Migrated from github.com)
Copy link
Copy source

Distinguish SQLITE_BUSY/timeouts from corruption; never delete the live DB on transient errors. AC: injected transient error does not trigger salvage/delete.

Distinguish SQLITE_BUSY/timeouts from corruption; never delete the live DB on transient errors. AC: injected transient error does not trigger salvage/delete.
KofTwentyTwo commented 2026-07-27 00:57:05 +00:00 (Migrated from github.com)
Copy link
Copy source

Quarantined a related flaky test while landing the green baseline: nunciod::orchestrator::tests::orchestrator_recovers_corrupted_database_and_emits_event is now #[ignore]d because DB-corruption detection intermittently races the WAL/file close in the recovery path (initialize_and_recover sometimes returns None for a corrupted DB). Re-enable and de-flake this test as part of this issue's recovery-reliability work.

Quarantined a related flaky test while landing the green baseline: `nunciod::orchestrator::tests::orchestrator_recovers_corrupted_database_and_emits_event` is now `#[ignore]`d because DB-corruption detection intermittently races the WAL/file close in the recovery path (`initialize_and_recover` sometimes returns `None` for a corrupted DB). Re-enable and de-flake this test as part of this issue's recovery-reliability work.
KofTwentyTwo commented 2026-07-27 04:02:55 +00:00 (Migrated from github.com)
Copy link
Copy source

Done on dev (ec07711): transient errors no longer trigger destructive salvage (allowlist classification + real SQLITE_BUSY test); and the flaky recovery test is de-flaked (deferred-WAL-checkpoint root cause; wal_checkpoint(TRUNCATE) on close; 130 runs 0 failures) and re-enabled.

Done on `dev` (ec07711): transient errors no longer trigger destructive salvage (allowlist classification + real SQLITE_BUSY test); and the flaky recovery test is de-flaked (deferred-WAL-checkpoint root cause; wal_checkpoint(TRUNCATE) on close; 130 runs 0 failures) and re-enabled.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area-ci
CI / quality gates
 area-cli
nuncio-cli reference client
 area-docs
Documentation
 area-grpc
gRPC API layer
 area-mail
Mail protocols
 area-release
Release / packaging
 area-security
Security
 area-store
Storage / SQLite
 bug
Something isn't working
 deferred
Backlog, off the critical path; re-justify before scheduling
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 phase-0
Roadmap Phase 0
 phase-1
Roadmap Phase 1
 phase-2
Roadmap Phase 2
 phase-3
Roadmap Phase 3
 phase-4
Roadmap Phase 4
 phase-5
Roadmap Phase 5
 question
Further information is requested
 rust
Pull requests that update rust code
 story
Roadmap story: full LLM-ready spec, done via engine+proto+CLI+E2E
 wontfix
This will not be worked on
No labels area-store phase-1
Milestone
No items
No Milestone Phase 1: gRPC skeleton and spine
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/nuncio#155