KofTwentyTwo/nuncio
2
0 Fork 0
Code Issues 73 Pull Requests 12 Actions Packages Projects Releases Wiki Activity

3.A Filter-engine correctness (scoping, ON ACCOUNT, non-ASCII offsets, NOT IN) #177

New Issue
Closed
opened 2026-07-27 13:11:52 +00:00 by KofTwentyTwo · 1 comment
KofTwentyTwo commented 2026-07-27 13:11:52 +00:00 (Migrated from github.com)
Copy link
Copy source

Phase 3 — Feature completeness (behind the API). Crate: nuncio-filter.

The NSQL filter engine is the strongest subsystem but has known correctness
defects surfaced in the 2026-07-26 assessment. Fix them, each with a regression
test, keeping the engine offline-testable.

Scope / acceptance criteria

  • Account scoping — filter evaluation respects the owning account; a rule
    created for account A does not match messages of account B. Regression test.
  • ON ACCOUNT clause — the NSQL ON ACCOUNT <id> predicate parses,
    validates, and constrains evaluation to that account. Parser + engine tests.
  • Non-ASCII offset bug — string offsets/spans are computed on char
    boundaries (not raw bytes) so rules over non-ASCII subjects/bodies match at
    the correct positions. Test with a multi-byte UTF-8 fixture.
  • NOT IN operator — NOT IN (...) evaluates as the complement of IN,
    including correct handling of the empty-set and NULL cases. Parser + engine tests.
  • cargo verify green; no new clippy waivers; comments state intent only.

Definition of done: engine + (if the surface changes) proto + CLI + offline test.

**Phase 3 — Feature completeness (behind the API).** Crate: `nuncio-filter`. The NSQL filter engine is the strongest subsystem but has known correctness defects surfaced in the 2026-07-26 assessment. Fix them, each with a regression test, keeping the engine offline-testable. ### Scope / acceptance criteria - [ ] **Account scoping** — filter evaluation respects the owning account; a rule created for account A does not match messages of account B. Regression test. - [ ] **`ON ACCOUNT` clause** — the NSQL `ON ACCOUNT <id>` predicate parses, validates, and constrains evaluation to that account. Parser + engine tests. - [ ] **Non-ASCII offset bug** — string offsets/spans are computed on `char` boundaries (not raw bytes) so rules over non-ASCII subjects/bodies match at the correct positions. Test with a multi-byte UTF-8 fixture. - [ ] **`NOT IN` operator** — `NOT IN (...)` evaluates as the complement of `IN`, including correct handling of the empty-set and NULL cases. Parser + engine tests. - [ ] `cargo verify` green; no new clippy waivers; comments state intent only. Definition of done: engine + (if the surface changes) proto + CLI + offline test.
KofTwentyTwo commented 2026-07-27 13:30:20 +00:00 (Migrated from github.com)
Copy link
Copy source

Delivered on dev (fdb5a3f): account scoping enforced in evaluate/evaluate_with_timeout/preview; find_keyword_outside_quotes returns true byte offsets (UTF-8 fix); NOT IN implemented as complement of IN via new NotIn operator. 26 tests, reviewed clean.

Delivered on dev (fdb5a3f): account scoping enforced in evaluate/evaluate_with_timeout/preview; find_keyword_outside_quotes returns true byte offsets (UTF-8 fix); NOT IN implemented as complement of IN via new NotIn operator. 26 tests, reviewed clean.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area-ci
CI / quality gates
 area-cli
nuncio-cli reference client
 area-docs
Documentation
 area-grpc
gRPC API layer
 area-mail
Mail protocols
 area-release
Release / packaging
 area-security
Security
 area-store
Storage / SQLite
 bug
Something isn't working
 deferred
Backlog, off the critical path; re-justify before scheduling
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 phase-0
Roadmap Phase 0
 phase-1
Roadmap Phase 1
 phase-2
Roadmap Phase 2
 phase-3
Roadmap Phase 3
 phase-4
Roadmap Phase 4
 phase-5
Roadmap Phase 5
 question
Further information is requested
 rust
Pull requests that update rust code
 story
Roadmap story: full LLM-ready spec, done via engine+proto+CLI+E2E
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/nuncio#177