KofTwentyTwo/nuncio
2
0 Fork 0
Code Issues 73 Pull Requests 12 Actions Packages Projects Releases Wiki Activity

contacts: low-severity follow-ups from M2-S2 review (guards, id uniqueness, CLI wording) #219

New Issue
Open
opened 2026-07-29 23:23:35 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-07-29 23:23:35 +00:00 (Migrated from github.com)
Copy link
Copy source

Non-blocking LOW findings from the M2-S2 (#188) review:

  1. ContactsGrpcService::sync doesn't validate empty account_id (List/Get/Create do) — add the same invalid_argument guard for symmetry.
  2. get_contact is not account-scoped (any authenticated caller can fetch any contact by id) — defer to a future per-account authz story (also affects other read RPCs; whole-daemon authz model).
  3. Contact::new id = ct_{millis}_{pid} + INSERT OR REPLACE: two CreateContact calls in the same millisecond/process collide and silently overwrite. Switch to a UUID. (Pre-existing from M2-S1; CreateContact is the first caller depending on it.)
  4. CLI contact add success string 'saved to address book' → say 'local address book (not yet synced to a server)' to preempt the created-but-not-synced foot-gun (proto/JSON layers already disclose local-only).
Non-blocking LOW findings from the M2-S2 (#188) review: 1. `ContactsGrpcService::sync` doesn't validate empty `account_id` (List/Get/Create do) — add the same `invalid_argument` guard for symmetry. 2. `get_contact` is not account-scoped (any authenticated caller can fetch any contact by id) — defer to a future per-account authz story (also affects other read RPCs; whole-daemon authz model). 3. `Contact::new` id = `ct_{millis}_{pid}` + `INSERT OR REPLACE`: two CreateContact calls in the same millisecond/process collide and silently overwrite. Switch to a UUID. (Pre-existing from M2-S1; CreateContact is the first caller depending on it.) 4. CLI `contact add` success string 'saved to address book' → say 'local address book (not yet synced to a server)' to preempt the created-but-not-synced foot-gun (proto/JSON layers already disclose local-only).
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area-ci
CI / quality gates
 area-cli
nuncio-cli reference client
 area-docs
Documentation
 area-grpc
gRPC API layer
 area-mail
Mail protocols
 area-release
Release / packaging
 area-security
Security
 area-store
Storage / SQLite
 bug
Something isn't working
 deferred
Backlog, off the critical path; re-justify before scheduling
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 phase-0
Roadmap Phase 0
 phase-1
Roadmap Phase 1
 phase-2
Roadmap Phase 2
 phase-3
Roadmap Phase 3
 phase-4
Roadmap Phase 4
 phase-5
Roadmap Phase 5
 question
Further information is requested
 rust
Pull requests that update rust code
 story
Roadmap story: full LLM-ready spec, done via engine+proto+CLI+E2E
 wontfix
This will not be worked on
No labels story
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/nuncio#219