KofTwentyTwo/nuncio
2
0 Fork 0
Code Issues 73 Pull Requests 12 Actions Packages Projects Releases Wiki Activity

M6 [P1]: Prevent deterministic rule-ID collisions (silent overwrite on CreateRule) #249

New Issue
Closed
opened 2026-07-31 14:40:31 +00:00 by KofTwentyTwo · 1 comment
KofTwentyTwo commented 2026-07-31 14:40:31 +00:00 (Migrated from github.com)
Copy link
Copy source

Rule IDs are sha256(name+nsql)[..8] (parser.rs:613-619) and CreateRule persists via INSERT OR REPLACE (db.rs:1533-1548) with no existence check — two rules with the same name+NSQL text silently overwrite each other (a user creating a second identical-looking rule destroys the first). Goal: generate a real unique id (or check existence and reject/î distinguish on CreateRule) so creating a rule can never silently clobber an existing one. Test the collision scenario.

Source: full-tree audit 2026-07-30 (scratchpad/audit/AUDIT-SUMMARY.md). Follow docs/STORY-WORKFLOW.md: engine+proto(if surface)+CLI+offline E2E, mock-only tests, no fabricated data, comment convention, PR to dev, PO reviews before close.

Rule IDs are `sha256(name+nsql)[..8]` (parser.rs:613-619) and CreateRule persists via `INSERT OR REPLACE` (db.rs:1533-1548) with no existence check — two rules with the same name+NSQL text silently overwrite each other (a user creating a second identical-looking rule destroys the first). Goal: generate a real unique id (or check existence and reject/î distinguish on CreateRule) so creating a rule can never silently clobber an existing one. Test the collision scenario. Source: full-tree audit 2026-07-30 (scratchpad/audit/AUDIT-SUMMARY.md). Follow docs/STORY-WORKFLOW.md: engine+proto(if surface)+CLI+offline E2E, mock-only tests, no fabricated data, comment convention, PR to dev, PO reviews before close.
KofTwentyTwo commented 2026-07-31 16:32:12 +00:00 (Migrated from github.com)
Copy link
Copy source

Delivered via PR #267 (squash-merged to dev). Filter rule ids are now a 16-byte CSPRNG-random hex value (reusing the existing aes-gcm OsRng, no new dep) instead of sha256(name+nsql), so CreateRule can never silently overwrite a different rule that happens to share name+NSQL. INSERT OR REPLACE is harmless with unique ids; UpdateRule/list still preserve the persisted id. Test proves two identical-name+nsql rules coexist as distinct rules.

Delivered via PR #267 (squash-merged to dev). Filter rule ids are now a 16-byte CSPRNG-random hex value (reusing the existing aes-gcm OsRng, no new dep) instead of sha256(name+nsql), so CreateRule can never silently overwrite a different rule that happens to share name+NSQL. INSERT OR REPLACE is harmless with unique ids; UpdateRule/list still preserve the persisted id. Test proves two identical-name+nsql rules coexist as distinct rules.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area-ci
CI / quality gates
 area-cli
nuncio-cli reference client
 area-docs
Documentation
 area-grpc
gRPC API layer
 area-mail
Mail protocols
 area-release
Release / packaging
 area-security
Security
 area-store
Storage / SQLite
 bug
Something isn't working
 deferred
Backlog, off the critical path; re-justify before scheduling
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 phase-0
Roadmap Phase 0
 phase-1
Roadmap Phase 1
 phase-2
Roadmap Phase 2
 phase-3
Roadmap Phase 3
 phase-4
Roadmap Phase 4
 phase-5
Roadmap Phase 5
 question
Further information is requested
 rust
Pull requests that update rust code
 story
Roadmap story: full LLM-ready spec, done via engine+proto+CLI+E2E
 wontfix
This will not be worked on
No labels bug
Milestone
No items
No Milestone M6: Security & release hardening
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/nuncio#249