M6 [P2]: Remove test theater (assertion-free backend tests; serve-result-swallowing test) #251

New Issue

2026-07-31T14:40:34Z

KofTwentyTwo commented

2026-07-31 14:40:34 +00:00

(Migrated from github.com)

sync.rs:789,796 build_mail_backend_constructs_{imap,jmap}_engine construct a Box<dyn MailBackend> and drop it with ZERO assertions (verify nothing under deny(panic/unwrap)). grpc.rs:2578 serve_binds_and_starts_on_a_valid_loopback_address does let _ = serve(...).await and returns — a bind failure is swallowed and the test still passes (on a security-adjacent bind-hardening path). Goal: give both real assertions (or delete if they cannot verify anything meaningful); the serve test must assert the bind actually succeeded.

Source: full-tree audit 2026-07-30 (scratchpad/audit/AUDIT-SUMMARY.md). Follow docs/STORY-WORKFLOW.md: engine+proto(if surface)+CLI+offline E2E, mock-only tests, no fabricated data, comment convention, PR to dev, PO reviews before close.

`sync.rs:789,796` `build_mail_backend_constructs_{imap,jmap}_engine` construct a `Box<dyn MailBackend>` and drop it with ZERO assertions (verify nothing under deny(panic/unwrap)). `grpc.rs:2578` `serve_binds_and_starts_on_a_valid_loopback_address` does `let _ = serve(...).await` and returns — a bind failure is swallowed and the test still passes (on a security-adjacent bind-hardening path). Goal: give both real assertions (or delete if they cannot verify anything meaningful); the serve test must assert the bind actually succeeded. Source: full-tree audit 2026-07-30 (scratchpad/audit/AUDIT-SUMMARY.md). Follow docs/STORY-WORKFLOW.md: engine+proto(if surface)+CLI+offline E2E, mock-only tests, no fabricated data, comment convention, PR to dev, PO reviews before close.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KofTwentyTwo/nuncio#251