KofTwentyTwo/nuncio
2
0 Fork 0
Code Issues 73 Pull Requests 12 Actions Packages Projects Releases Wiki Activity

WS-C1 Graceful shutdown: signal -> serve_with_shutdown -> drain -> db.close() WAL checkpoint #289

New Issue
Closed
opened 2026-07-31 18:14:11 +00:00 by KofTwentyTwo · 1 comment
KofTwentyTwo commented 2026-07-31 18:14:11 +00:00 (Migrated from github.com)
Copy link
Copy source

Single CancellationToken owned by main.rs; bounded grace; the WAL-checkpointing db.close() (never called in prod today -> corruption risk on every OS kill). Ship first so all workers are cancel-aware. Size M.

Roadmap-to-9/10 (design: scratchpad/design/). Serial PROTO queue via WS-A. Brief at dispatch. DoD per docs/STORY-WORKFLOW.md.

Single CancellationToken owned by main.rs; bounded grace; the WAL-checkpointing db.close() (never called in prod today -> corruption risk on every OS kill). Ship first so all workers are cancel-aware. Size M. Roadmap-to-9/10 (design: scratchpad/design/). Serial PROTO queue via WS-A. Brief at dispatch. DoD per docs/STORY-WORKFLOW.md.
KofTwentyTwo commented 2026-07-31 18:55:20 +00:00 (Migrated from github.com)
Copy link
Copy source

Delivered via PR #340 (WS-C1, squash-merged to dev). Graceful shutdown: watch-based ShutdownSignal (no new dep) + Ctrl+C/SIGTERM handlers; gRPC via serve_with_shutdown (existing serve delegates -> no test churn); sync/outbox/update workers rewritten as cancel-safe select!; bounded 10s grace then an unconditional db.close() (forces the WAL checkpoint that was never run in prod -> closes the corruption-on-kill risk). 2 tests prove server-stops + worker-exits + db.close runs. Lifecycle foundation for the rest of WS-C.

Delivered via PR #340 (WS-C1, squash-merged to dev). Graceful shutdown: watch-based ShutdownSignal (no new dep) + Ctrl+C/SIGTERM handlers; gRPC via serve_with_shutdown (existing serve delegates -> no test churn); sync/outbox/update workers rewritten as cancel-safe select!; bounded 10s grace then an unconditional db.close() (forces the WAL checkpoint that was never run in prod -> closes the corruption-on-kill risk). 2 tests prove server-stops + worker-exits + db.close runs. Lifecycle foundation for the rest of WS-C.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area-ci
CI / quality gates
 area-cli
nuncio-cli reference client
 area-docs
Documentation
 area-grpc
gRPC API layer
 area-mail
Mail protocols
 area-release
Release / packaging
 area-security
Security
 area-store
Storage / SQLite
 bug
Something isn't working
 deferred
Backlog, off the critical path; re-justify before scheduling
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 phase-0
Roadmap Phase 0
 phase-1
Roadmap Phase 1
 phase-2
Roadmap Phase 2
 phase-3
Roadmap Phase 3
 phase-4
Roadmap Phase 4
 phase-5
Roadmap Phase 5
 question
Further information is requested
 rust
Pull requests that update rust code
 story
Roadmap story: full LLM-ready spec, done via engine+proto+CLI+E2E
 wontfix
This will not be worked on
No labels story
Milestone
No items
No Milestone WS-C: Sync, push & lifecycle
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/nuncio#289