KofTwentyTwo/nuncio
2
0 Fork 0
Code Issues 73 Pull Requests 12 Actions Packages Projects Releases Wiki Activity

WS-D10 Pin resolved IP for webhook dispatch to close the DNS-rebind TOCTOU #306

New Issue
Closed
opened 2026-07-31 18:14:39 +00:00 by KofTwentyTwo · 1 comment
KofTwentyTwo commented 2026-07-31 18:14:39 +00:00 (Migrated from github.com)
Copy link
Copy source

Documented residual from #203. Size S.

Roadmap-to-9/10 (design: scratchpad/design/). Serial PROTO queue via WS-A. Brief at dispatch. DoD per docs/STORY-WORKFLOW.md.

Documented residual from #203. Size S. Roadmap-to-9/10 (design: scratchpad/design/). Serial PROTO queue via WS-A. Brief at dispatch. DoD per docs/STORY-WORKFLOW.md.
KofTwentyTwo commented 2026-07-31 19:15:54 +00:00 (Migrated from github.com)
Copy link
Copy source

Delivered via PR #343 (WS-D10, squash-merged to dev). Webhook dispatch resolves the host once, checks every candidate IP (is_blocked_webhook_target, #203), then pins the connection to the checked IP via reqwest .resolve(host,addr) (SNI/Host preserved) so reqwest cannot re-resolve — closes the DNS-rebind TOCTOU by construction. Unresolvable-.invalid + wiremock-loopback test proves the checked IP is used. Residual single-DNS-answer trust documented out-of-scope. (Note: the PR body references #307 due to a PO mis-numbering at dispatch; the real issue is this #306.)

Delivered via PR #343 (WS-D10, squash-merged to dev). Webhook dispatch resolves the host once, checks every candidate IP (is_blocked_webhook_target, #203), then pins the connection to the checked IP via reqwest .resolve(host,addr) (SNI/Host preserved) so reqwest cannot re-resolve — closes the DNS-rebind TOCTOU by construction. Unresolvable-.invalid + wiremock-loopback test proves the checked IP is used. Residual single-DNS-answer trust documented out-of-scope. (Note: the PR body references #307 due to a PO mis-numbering at dispatch; the real issue is this #306.)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area-ci
CI / quality gates
 area-cli
nuncio-cli reference client
 area-docs
Documentation
 area-grpc
gRPC API layer
 area-mail
Mail protocols
 area-release
Release / packaging
 area-security
Security
 area-store
Storage / SQLite
 bug
Something isn't working
 deferred
Backlog, off the critical path; re-justify before scheduling
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 phase-0
Roadmap Phase 0
 phase-1
Roadmap Phase 1
 phase-2
Roadmap Phase 2
 phase-3
Roadmap Phase 3
 phase-4
Roadmap Phase 4
 phase-5
Roadmap Phase 5
 question
Further information is requested
 rust
Pull requests that update rust code
 story
Roadmap story: full LLM-ready spec, done via engine+proto+CLI+E2E
 wontfix
This will not be worked on
No labels story
Milestone
No items
No Milestone WS-D: Security to 9/10
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/nuncio#306