KofTwentyTwo/nuncio
2
0 Fork 0
Code Issues 73 Pull Requests 12 Actions Packages Projects Releases Wiki Activity

OBS-4 Filter engine instrumentation + silent eval-timeout FIX #360

New Issue
Closed
opened 2026-07-31 22:40:37 +00:00 by KofTwentyTwo · 1 comment
KofTwentyTwo commented 2026-07-31 22:40:37 +00:00 (Migrated from github.com)
Copy link
Copy source

FIX engine.rs:298 unwrap_or_default() — rule-eval/ReDoS timeout silently disables filtering; must warn+fail visibly. Add per-rule-fire debug, reload_rules info, webhook egress + SSRF-block-decision logging. Highest leverage; security-relevant bug. Part of the Observability-to-9/10 program. Full brief: scratchpad/design/OBS-ROADMAP.md. DoD per docs/STORY-WORKFLOW.md; gate green; no unwrap/expect/panic in non-test; SSH-signed; PR to dev.

FIX engine.rs:298 unwrap_or_default() — rule-eval/ReDoS timeout silently disables filtering; must warn+fail visibly. Add per-rule-fire debug, reload_rules info, webhook egress + SSRF-block-decision logging. Highest leverage; security-relevant bug. Part of the Observability-to-9/10 program. Full brief: scratchpad/design/OBS-ROADMAP.md. DoD per docs/STORY-WORKFLOW.md; gate green; no unwrap/expect/panic in non-test; SSH-signed; PR to dev.
KofTwentyTwo commented 2026-07-31 23:34:53 +00:00 (Migrated from github.com)
Copy link
Copy source

Delivered via PR #369 (OBS-4). engine.rs:298 unwrap_or_default() silent eval-timeout FIXED: per-rule eval on spawn_blocking, explicit match, timeout -> warn!(rule_id,rule_name,timeout_ms) + fail-closed non-match, batch continues. Also fixed a deeper latent bug: the old timeout wrapped a synchronous non-yielding future so it was structurally unreachable for CPU-bound rules. Added reload_rules info!, per-rule-fire debug! (action KINDS only, no folder/addr/url), webhook egress span + SSRF/DNS-rebind block-decision logging (host/ip only). Secret-safety grep clean; 4 new tests.

Delivered via PR #369 (OBS-4). engine.rs:298 unwrap_or_default() silent eval-timeout FIXED: per-rule eval on spawn_blocking, explicit match, timeout -> warn!(rule_id,rule_name,timeout_ms) + fail-closed non-match, batch continues. Also fixed a deeper latent bug: the old timeout wrapped a synchronous non-yielding future so it was structurally unreachable for CPU-bound rules. Added reload_rules info!, per-rule-fire debug! (action KINDS only, no folder/addr/url), webhook egress span + SSRF/DNS-rebind block-decision logging (host/ip only). Secret-safety grep clean; 4 new tests.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
area-ci
CI / quality gates
 area-cli
nuncio-cli reference client
 area-docs
Documentation
 area-grpc
gRPC API layer
 area-mail
Mail protocols
 area-release
Release / packaging
 area-security
Security
 area-store
Storage / SQLite
 bug
Something isn't working
 deferred
Backlog, off the critical path; re-justify before scheduling
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 phase-0
Roadmap Phase 0
 phase-1
Roadmap Phase 1
 phase-2
Roadmap Phase 2
 phase-3
Roadmap Phase 3
 phase-4
Roadmap Phase 4
 phase-5
Roadmap Phase 5
 question
Further information is requested
 rust
Pull requests that update rust code
 story
Roadmap story: full LLM-ready spec, done via engine+proto+CLI+E2E
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/nuncio#360