fix(releases): scope bootstrap parameters under Actions pwsh #45
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: KofTwentyTwo/standards#45
Reference in new issue
Block a user
Both1.0.1 production runs reached the fixed builder after full acceptance. The inline dependency bootstrap failed with
param is not recognizedbecause GitHub's default pwsh shell inserts$ErrorActionPreference = 'stop'before the run body. The previous standalone-script test did not model that wrapper; this was my implementation error.Invoke the existing parameterized bootstrap inside a script block and pass its arguments through. Preserve every package URL/version/hash/signature check, destination guard, official action input and Azure trust scope. Update tests to execute the actual run body after GitHub's preamble.
Validation: added the preamble to the existing real-body test first and reproduced all five bootstrap cases failing with the exact hosted param error in2.26sec; after the fix40 signing tests pass with zero skips. The actual corrected wrapped body also downloads/verifies Microsoft's real pinned package and starts its CLI. Configured script analysis, actionlint, zizmor medium gate and diff checks pass. No production signing/publication success claimed.
Refs #43 and KofTwentyTwo/MarkdownViewr.Windows#33. Substantial AI assistance: Codex GPT-6. Required genuine maintainer review before merge; app release authorization already exists.
Automated review of exact head
aa6b0f6277(Codex): no findings identified in this two-file correction.The inline pwsh dependency bootstrap now invokes a parameterized script block, avoiding GitHub's prepended ErrorActionPreference statement invalidating a top-level param block. All package/version/hash/NuGet signature checks, destination guards, official signing action inputs and Azure trust remain unchanged. The regression test prepends the actual GitHub default pwsh statement. Five bootstrap cases fail before correction; all40 signing tests pass afterward. Actual wrapped Microsoft package verification/CLI startup and all hosted checks pass.
Genuine maintainer review is requested and pending. This automated review does not assert a human acknowledgement or production signing success.
The maintainer personally confirmed in the active session: "confirmed - approved", responding to the review request for this exact head
aa6b0f6277. All hosted checks pass; the two-file corrected PowerShell wrapper and regression test were reviewed. Release publication is already authorized.