QRun-IO/qbit-alerts
3
0 Fork 0
Code Issues 2 Pull Requests 5 Actions Packages Projects Releases 18 Wiki Activity

Quiet hours, digests, reminders and escalation are stored and editable but never applied #27

New Issue
Open
opened 2026-10-14 15:24:54 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-10-14 15:24:54 +00:00 (Migrated from github.com)
Copy link
Copy source

Found while writing the in-app help text (Website-Backend#196). (kof22 pins 0.1.0-RC.2; verified on origin/develop ee002b2.)

  • Quiet hours: the Quiet Hours and Digests section (AlertsTableMetaDataHelper.java:281) edits quietHoursStart/End/Days, but nothing reads them: git grep 'QUIET_HOURS\|getQuietHours' -- src/main/java only finds the enum value (AlertsPossibleValues.java:226) and the model getters (AlertsUserPreference.java). The router never suppresses with reason QUIET_HOURS.
  • Digests: digestHour (AlertsPreferences.java:82) and the digest template (AlertsEmailSender.java:58,192) exist, but no engine/router code sends a DIGEST for alerts.
  • Escalation / reminders: escalationLevel is initialised to 0 (AlertsEngine.java:471) and Resolution EXPIRED (AlertsPossibleValues.java:115) is never set; ESCALATED/REMINDER are enum values mapped in AlertRouter.java:124 but nothing raises them.
  • Team member sources Role and IdP Group are stored but never resolved.
  • The per-alert Mute action mutes the whole alert type, and a mute with scope Record never matches because no record id is passed.

Expected: implement, or hide the fields/actions until built, so the form does not suggest they work. (The README already lists several as not built yet.)

Found while writing the in-app help text (Website-Backend#196). (kof22 pins 0.1.0-RC.2; verified on origin/develop ee002b2.) - **Quiet hours:** the **Quiet Hours and Digests** section (AlertsTableMetaDataHelper.java:281) edits `quietHoursStart/End/Days`, but nothing reads them: `git grep 'QUIET_HOURS\|getQuietHours' -- src/main/java` only finds the enum value (AlertsPossibleValues.java:226) and the model getters (AlertsUserPreference.java). The router never suppresses with reason QUIET_HOURS. - **Digests:** `digestHour` (AlertsPreferences.java:82) and the digest template (AlertsEmailSender.java:58,192) exist, but no engine/router code sends a DIGEST for alerts. - **Escalation / reminders:** `escalationLevel` is initialised to 0 (AlertsEngine.java:471) and Resolution `EXPIRED` (AlertsPossibleValues.java:115) is never set; ESCALATED/REMINDER are enum values mapped in AlertRouter.java:124 but nothing raises them. - Team member sources Role and IdP Group are stored but never resolved. - The per-alert **Mute** action mutes the whole alert type, and a mute with scope Record never matches because no record id is passed. **Expected:** implement, or hide the fields/actions until built, so the form does not suggest they work. (The README already lists several as not built yet.)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
ux
Admin UX / information architecture
 wontfix
This will not be worked on
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-alerts#27