QRun-IO/qbit-alerts
3
0 Fork 0
Code Issues 2 Pull Requests 5 Actions Packages Projects Releases 18 Wiki Activity

fix(alerts): asSystem builds its system session with the runtime instance #42

Merged
KofTwentyTwo merged 1 commits from fix/alerts-system-session-instance into develop 2026-10-15 12:38:27 +00:00
Conversation 0 Commits 1 Files Changed 3
+70 -2
KofTwentyTwo commented 2026-10-15 12:26:13 +00:00 (Migrated from github.com)
Copy link
Copy source

Production noise fix (kof22): the alerts-sink drain thread runs engine work through AlertsRuntime.asSystem without a QContext. AlertsSecurity.systemSession() called new QSystemUserSession(), which read a null instance. Every call logged the WARN "QInstance was not supplied when creating a QSystemUserSession", and the session had no core all-access keys.

  • New AlertsSecurity.systemSession(QInstance). asSystem passes the runtime's instance. The no-arg form now delegates using the context instance.
  • AlertsSystemSessionTest: asSystem with an empty QContext runs as the system user and logs no warning. It failed before this change.

./mvnw verify passes locally. The matching core fix for the qqq-jobs-sched-* threads is QRun-IO/qqq#1222. Merging with release:rc cuts the next RC.

🤖 Generated with Claude Code

Production noise fix (kof22): the `alerts-sink` drain thread runs engine work through `AlertsRuntime.asSystem` without a QContext. `AlertsSecurity.systemSession()` called `new QSystemUserSession()`, which read a null instance. Every call logged the WARN "QInstance was not supplied when creating a QSystemUserSession", and the session had no core all-access keys. - New `AlertsSecurity.systemSession(QInstance)`. `asSystem` passes the runtime's instance. The no-arg form now delegates using the context instance. - `AlertsSystemSessionTest`: `asSystem` with an empty QContext runs as the system user and logs no warning. It failed before this change. `./mvnw verify` passes locally. The matching core fix for the `qqq-jobs-sched-*` threads is QRun-IO/qqq#1222. Merging with `release:rc` cuts the next RC. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
ux
Admin UX / information architecture
 wontfix
This will not be worked on
No labels release:rc
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-alerts#42