fix(app): Backups Setup and Needs attention agree #32

Merged
KofTwentyTwo merged 1 commits from feature/backups-setup-attention-consistent into develop 2026-10-16 15:19:50 +00:00
KofTwentyTwo commented 2026-10-16 14:08:27 +00:00 (Migrated from github.com)

Summary

The backupsHome widget computed the Setup card and the Needs attention card from different sources, so they contradicted each other. The Setup items are now loaded once in render, and Needs attention lists every Setup item in the "Needs setup" state (linked to its table) in addition to plans in a problem state (including UNVERIFIED) and failed runs. The empty text only shows when all three are empty, so the two cards always agree.

Rubric item moved

A2 consistency on Backups (backups): stays 1. Attention does not move to first position until wave 3; this PR only removes the contradiction.

Audit row fixed

Backups A2: "It contradicts Setup: Setup reports '1 item needs attention' (storage aliases backupsAws, backupsAwsPrune do not resolve...), while Needs attention says 'Nothing needs attention.'"

Tests

  • New BackupsHomeTest.testUnresolvedAliasAppearsInSetupAndNeedsAttention: unresolved backupsAws/backupsAwsPrune shows in Setup and in Needs attention, and the Needs attention item count equals Setup TODOs + plan problems + failed runs.
  • Updated testEmptyStates (no plans: the no-plan Setup fault is now listed as attention).
  • Ran BackupsHomeTest, BackupsSetupStatusTest (13 pass) via ./mvnw; full verify left to CI.

Screenshots

Widget-level before/after at 390, 768, 1024, 1440, 1920, 3200, attached locally: C:\Users\james\AppData\Local\Temp\claude\R--Git-Local-KofTwentyTwo-Praetor\83da0ae2-628c-4edb-9fd7-a93d49e86d27\scratchpad\dashboard-standard\pr-shots\backups-attn\ (before-<w>.png, after-<w>.png). Full-page shots happen when kof22 pins the release.

Release

A qbit-backups RC release is needed (next after 0.1.0-RC.8). kof22 (Website-Backend) pom.xml currently pins qbit-backups.version 0.1.0-RC.8 on origin/main and must be bumped to the new RC.

🤖 Generated with Claude Code

## Summary The `backupsHome` widget computed the Setup card and the Needs attention card from different sources, so they contradicted each other. The Setup items are now loaded once in `render`, and Needs attention lists every Setup item in the "Needs setup" state (linked to its table) in addition to plans in a problem state (including UNVERIFIED) and failed runs. The empty text only shows when all three are empty, so the two cards always agree. ## Rubric item moved A2 consistency on Backups (`backups`): stays 1. Attention does not move to first position until wave 3; this PR only removes the contradiction. ## Audit row fixed Backups A2: "It contradicts Setup: Setup reports '1 item needs attention' (storage aliases `backupsAws`, `backupsAwsPrune` do not resolve...), while Needs attention says 'Nothing needs attention.'" ## Tests - New `BackupsHomeTest.testUnresolvedAliasAppearsInSetupAndNeedsAttention`: unresolved `backupsAws`/`backupsAwsPrune` shows in Setup and in Needs attention, and the Needs attention item count equals Setup TODOs + plan problems + failed runs. - Updated `testEmptyStates` (no plans: the no-plan Setup fault is now listed as attention). - Ran `BackupsHomeTest`, `BackupsSetupStatusTest` (13 pass) via `./mvnw`; full verify left to CI. ## Screenshots Widget-level before/after at 390, 768, 1024, 1440, 1920, 3200, attached locally: `C:\Users\james\AppData\Local\Temp\claude\R--Git-Local-KofTwentyTwo-Praetor\83da0ae2-628c-4edb-9fd7-a93d49e86d27\scratchpad\dashboard-standard\pr-shots\backups-attn\` (`before-<w>.png`, `after-<w>.png`). Full-page shots happen when kof22 pins the release. ## Release A qbit-backups RC release is needed (next after 0.1.0-RC.8). kof22 (Website-Backend) `pom.xml` currently pins `qbit-backups.version` 0.1.0-RC.8 on origin/main and must be bumped to the new RC. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.