QRun-IO/qbit-cdn
3
0 Fork 0
Code Issues 2 Pull Requests 5 Actions Packages Projects Releases 10 Wiki Activity

CI: a hotfix/* branch push publishes a GA release with no tag or review gate #12

New Issue
Open
opened 2026-10-13 01:09:03 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-10-13 01:09:03 +00:00 (Migrated from github.com)
Copy link
Copy source

Problem

.circleci/config.yml runs publish_hotfix_release (qqq-orb/mvn_publish, branch_type: hotfix) on any push to a hotfix/* branch. The orb then bumps the patch version and publishes a GA release to Maven Central, with no tag, no review and no merge gate.

Evidence

On 2026-10-13, a push to hotfix/tag-rule-pvs-table (commit 26e62f3) published com.kingsrook.qbits:qbit-cdn:0.1.1 to Central (CircleCI 14). Only the "Create GitHub Release" step failed. The content happened to be correct, but nothing required it to be. A tag was added afterwards for provenance: https://github.com/QRun-IO/qbit-cdn/releases/tag/v0.1.1

Proposal

Hotfix publishing should require a tag, like GA:

  • either drop publish_hotfix_release and publish hotfixes only from a reviewed vX.Y.Z tag on the hotfix commit (the existing publish_release workflow, filter /^v\d+\.\d+\.\d+$/),
  • or keep a hotfix workflow but filter it on tags only, never on branch pushes.

hotfix/* branch pushes should run test_only only. The same change applies to every qbit that copied this config. The standard is tracked in QRun-IO/qqq docs/QRUN-QBIT-REPO-STANDARD.md.

🤖 Generated with Claude Code

## Problem `.circleci/config.yml` runs `publish_hotfix_release` (`qqq-orb/mvn_publish`, `branch_type: hotfix`) on **any push to a `hotfix/*` branch**. The orb then bumps the patch version and publishes a **GA release to Maven Central**, with no tag, no review and no merge gate. ## Evidence On 2026-10-13, a push to `hotfix/tag-rule-pvs-table` (commit `26e62f3`) published `com.kingsrook.qbits:qbit-cdn:0.1.1` to Central ([CircleCI 14](https://circleci.com/gh/QRun-IO/qbit-cdn/14)). Only the "Create GitHub Release" step failed. The content happened to be correct, but nothing required it to be. A tag was added afterwards for provenance: https://github.com/QRun-IO/qbit-cdn/releases/tag/v0.1.1 ## Proposal Hotfix publishing should require a tag, like GA: - either drop `publish_hotfix_release` and publish hotfixes only from a reviewed `vX.Y.Z` tag on the hotfix commit (the existing `publish_release` workflow, filter `/^v\d+\.\d+\.\d+$/`), - or keep a hotfix workflow but filter it on tags only, never on branch pushes. `hotfix/*` branch pushes should run `test_only` only. The same change applies to every qbit that copied this config. The standard is tracked in QRun-IO/qqq `docs/QRUN-QBIT-REPO-STANDARD.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
ux
Admin UX / information architecture
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-cdn#12