QRun-IO/qbit-cdn
3
0 Fork 0
Code Issues 2 Pull Requests 5 Actions Packages Projects Releases 10 Wiki Activity

Sign revalidation hooks with core WebhookSigner instead of ad-hoc HMAC #15

New Issue
Closed
opened 2026-10-14 00:14:41 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-10-14 00:14:41 +00:00 (Migrated from github.com)
Copy link
Copy source

purge/RevalidationHookRunner.java:195-196 hand-rolls HMAC-SHA256. Use core WebhookSigner (RC.5), the Standard Webhooks format, and the SSRF-safe client.

Source: Architecture review QRun-IO/qqq#1150 (docs/ARCHITECTURE-REVIEW-2026-10-13.md), finding F11.

`purge/RevalidationHookRunner.java:195-196` hand-rolls HMAC-SHA256. Use core `WebhookSigner` (RC.5), the Standard Webhooks format, and the SSRF-safe client. Source: Architecture review QRun-IO/qqq#1150 (docs/ARCHITECTURE-REVIEW-2026-10-13.md), finding F11.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
ux
Admin UX / information architecture
 wontfix
This will not be worked on
No labels architecture
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-cdn#15