QRun-IO/qbit-cdn
3
0 Fork 0
Code Issues 2 Pull Requests 5 Actions Packages Projects Releases 10 Wiki Activity

fix(purge): resolve tag-rule joined tables via possible-value source #9

Closed
KofTwentyTwo wants to merge 1 commits from hotfix/tag-rule-pvs-table into develop
pull from: hotfix/tag-rule-pvs-table
merge into: QRun-IO:develop
Conversation 1 Commits 1 Files Changed 1
+153 -8
KofTwentyTwo commented 2026-10-13 00:41:41 +00:00 (Migrated from github.com)
Copy link
Copy source

Problem

`TagRuleEngine` used a placeholder prefix as both the FK field name and the table name: `{blog.slug}` read `blogId` then GOT table `blog`. Apps with prefixed tables (kof22 `cms_blog`) silently lost those purge paths.

Fix

  • The joined table is resolved from `Id`'s possible-value source (table name for TABLE-type, or the PVS name when it names a table); fallback to the bare prefix keeps existing behaviour.
  • A missing joined table no longer skips silently: warn once per table per engine; a missing FK field/value is skipped without throwing.
  • README section on placeholders and CHANGELOG 0.1.1 entry.

Tests

Prefixed table via PVS, PVS-named-as-table, bare-prefix fallback, missing FK field, missing/dangling table. `CI=true ./mvnw verify`: 77 tests pass, checkstyle and coverage checks met.

🤖 Generated with Claude Code

## Problem \`TagRuleEngine\` used a placeholder prefix as both the FK field name and the table name: \`{blog.slug}\` read \`blogId\` then GOT table \`blog\`. Apps with prefixed tables (kof22 \`cms_blog\`) silently lost those purge paths. ## Fix - The joined table is resolved from \`<prefix>Id\`'s possible-value source (table name for TABLE-type, or the PVS name when it names a table); fallback to the bare prefix keeps existing behaviour. - A missing joined table no longer skips silently: warn once per table per engine; a missing FK field/value is skipped without throwing. - README section on placeholders and CHANGELOG 0.1.1 entry. ## Tests Prefixed table via PVS, PVS-named-as-table, bare-prefix fallback, missing FK field, missing/dangling table. \`CI=true ./mvnw verify\`: 77 tests pass, checkstyle and coverage checks met. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
KofTwentyTwo commented 2026-10-13 00:47:46 +00:00 (Migrated from github.com)
Copy link
Copy source

Superseded by the fix/tag-rule-pvs-table PR (same commit); the hotfix/* branch name triggers the publish workflow.

Superseded by the fix/tag-rule-pvs-table PR (same commit); the hotfix/* branch name triggers the publish workflow.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
ux
Admin UX / information architecture
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-cdn#9